Skip to content

Update Installation.md#6004

Merged
alex-mccarthy-unity merged 1 commit into
Unity-Technologies:developfrom
xyz2022:patch-1
Mar 11, 2024
Merged

Update Installation.md#6004
alex-mccarthy-unity merged 1 commit into
Unity-Technologies:developfrom
xyz2022:patch-1

Conversation

@xyz2022

@xyz2022 xyz2022 commented Oct 31, 2023

Copy link
Copy Markdown
Contributor

Removing "or higher" because:
(i) ./ml-agents/setup.py requires >=3.10.1,<=3.10.12 (ii) python 3.10.13 is the default conda install, and 3.10.13 does not work correctly with numpy 1.21.2

Proposed change(s)

Remove the phrase "or higher" from "Install Python 3.10.12 or Higher"

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

30fbd50

This is one issue related to the "or higher" clause on the python version:
#6002

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Removing "or higher" because:
(i) ./ml-agents/setup.py requires >=3.10.1,<=3.10.12 
(ii) python 3.10.13 is the default conda install, and 3.10.13 does not work correctly with numpy 1.21.2
@CLAassistant

CLAassistant commented Oct 31, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@alex-mccarthy-unity alex-mccarthy-unity left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs! I'll merge this in.

@alex-mccarthy-unity alex-mccarthy-unity merged commit ed807e3 into Unity-Technologies:develop Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants