Skip to content

Fix #5799#5951

Merged
miguelalonsojr merged 1 commit into
Unity-Technologies:developfrom
JesseTG:jtg/fix-5799-again
Jul 24, 2023
Merged

Fix #5799#5951
miguelalonsojr merged 1 commit into
Unity-Technologies:developfrom
JesseTG:jtg/fix-5799-again

Conversation

@JesseTG

@JesseTG JesseTG commented Jul 21, 2023

Copy link
Copy Markdown
Contributor

Proposed change(s)

Fix #5799, but on develop this time as requested in #5820.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

#5799
#5820
#5926

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

miguelalonsojr
miguelalonsojr approved these changes Jul 24, 2023
View reviewed changes

@miguelalonsojr miguelalonsojr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miguelalonsojr miguelalonsojr merged commit 47d0785 into Unity-Technologies:develop Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@miguelalonsojr miguelalonsojr miguelalonsojr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler errors when using IAsyncEnumerable<T> with .NET Standard 2.1 enabled

2 participants

@JesseTG @miguelalonsojr