Return deterministic actions #5597
Merged
cmard merged 16 commits intoNov 15, 2021
Merged
Conversation
cmard
changed the base branch from
main
to
deterministic-actions-python-training
miguelalonsojr
suggested changes
Oct 29, 2021
miguelalonsojr
left a comment
miguelalonsojr
left a comment
Contributor
There was a problem hiding this comment.
Please see CR feedback.
| # During training, clipping is done in TorchPolicy, but we need to clip before ONNX | ||
| # export as well. | ||
| self._clip_action_on_export = not tanh_squash | ||
| self.deterministic = deterministic |
Contributor
There was a problem hiding this comment.
Unless it's going to be used outside of the ActionModel class, refactor to make it
self._deterministic.
Co-authored-by: Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com>
Co-authored-by: Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com>
Co-authored-by: Miguel Alonso Jr. <76960110+miguelalonsojr@users.noreply.github.com>
maryamhonari
suggested changes
Oct 29, 2021
maryamhonari
left a comment
maryamhonari
left a comment
Contributor
There was a problem hiding this comment.
looks great! Some nit changes on docs and I believe the setting test for yaml is not set right and I wonder how it's passing CI.
| action_spec: ActionSpec, | ||
| conditional_sigma: bool = False, | ||
| tanh_squash: bool = False, | ||
| deterministic: bool = False, |
Contributor
There was a problem hiding this comment.
please update the docstring
| test1_settings = run_options.behaviors["test1"] | ||
| assert test1_settings.max_steps == 2 | ||
| assert test1_settings.network_settings.hidden_units == 2000 | ||
| assert not test1_settings.network_settings.deterministic |
Contributor
There was a problem hiding this comment.
nit: can we use == True just for readability
| agent_action1 = action_model._sample_action(dists) | ||
| agent_action2 = action_model._sample_action(dists) | ||
| agent_action3 = action_model._sample_action(dists) | ||
| assert torch.equal(agent_action1.continuous_tensor, agent_action2.continuous_tensor) |
Contributor
There was a problem hiding this comment.
some tests on discrete actions would be great!
| test1_settings = run_options.behaviors["test1"] | ||
| assert test1_settings.max_steps == 2 | ||
| assert test1_settings.network_settings.hidden_units == 2000 | ||
| assert not test1_settings.network_settings.deterministic |
Contributor
There was a problem hiding this comment.
IIUC this test is wrong. Above we set deterministic: true in yaml, so it should be assert test1_settings.network_settings.deterministic == True, right
?
Co-authored-by: Maryam Honari <honari.m94@gmail.com>
Co-authored-by: Maryam Honari <honari.m94@gmail.com>
Co-authored-by: Maryam Honari <honari.m94@gmail.com>
…y-Technologies/ml-agents into develop-staging-determinstic-action
10 tasks
maryamhonari
reviewed
Nov 3, 2021
Co-authored-by: Maryam Honari <honari.m94@gmail.com>
delete-merged-branch
Bot
deleted the
develop-staging-determinstic-action
branch
10 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
This PR will add an ability to retrieve actions deterministically based on the input to the model. A new run-options configuration has been added as well as a new CLI flag
--deterministic.Types of change(s)
Checklist
Other comments