Following petting_zoo registry API#5557
Conversation
maryamhonari
force-pushed
the
exp-petting-registry
branch
from
4350837 to
965f271
Compare
maryamhonari
force-pushed
the
exp-petting-registry
branch
from
a1ef25b to
18b6796
Compare
ToRevert: pull exp-petting-registry branch
maryamhonari
changed the title
Install pettingzoo-unity requirements for pytest
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
Left some comments. Looks good overall.
| terminated teammates. (#5441) | ||
| - Fixed wrong attribute name in argparser for torch device option (#5433)(#5467) | ||
| - Fixed conflicting CLI and yaml options regarding resume & initialize_from (#5495) | ||
| - Added minimal analytics collection to LL-API (#5511) |
There was a problem hiding this comment.
strange that this PR would contain this change, are you sure you cherry picked the right commits?
There was a problem hiding this comment.
yes this commit contains the default analytics side channels for custom trainers.
maryamhonari
force-pushed
the
exp-petting-registry
branch
2 times, most recently
from
7b4cd0f to
cb869c8
Compare
miguelalonsojr
left a comment
miguelalonsojr
left a comment
There was a problem hiding this comment.
Looks good. +1 to all the current comments and fixes, and I just added one. Cheers!
update the clone branch in colab
maryamhonari
force-pushed
the
exp-petting-registry
branch
from
cb869c8 to
532fd27
Compare
maryamhonari
force-pushed
the
exp-petting-registry
branch
from
96a58d3 to
abec580
Compare
vincentpierre
left a comment
vincentpierre
left a comment
There was a problem hiding this comment.
Looks good to me. Please wait on another approval to merge
|
|
||
| # Register each environment in default_registry as a PettingZooEnv | ||
| for key in default_registry: | ||
| key = key.replace("3", "Three") |
There was a problem hiding this comment.
This line does not look scalable. Is there a better way to do it. Like having a constant dictionary of key to replace value?
There was a problem hiding this comment.
Totally. However, a complete solution to this is non-trival. We could use a package like inflect (https://pypi.org/project/inflect/), however, this would require splitting the string into it's composite integer characters and letter components, convert the integer characters to their word equivalent, and then recombining, since inflect's number_to_words() strips all other non-numeric characters. This would be the most scalable solution, however, not sure if the added complexity is worth it at this point, since this really only applies to 3DBall.
* init petting_zoo registry * cherrypick Custom trainer editor analytics (#5511) * cherrypick "Update dotnet-format to address breaking changes introduced by upstream changes (#5528)" * Update colab to match pettingZoo import api * ToRevert: pull exp-petting-registry branch * Add init file to tests * Install pettingzoo-unity requirements for pytest * update pytest command * Add docstrings and comments * update coverage to pettingzoo folder * unset log level * update env string
3 participants
Proposed change(s)
Follow the pettingZoo environment import:
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
https://jira.unity3d.com/browse/MLA-2235
Try this for democolab link for this branch
Types of change(s)
Checklist
Other comments