[FIX] prioritize cli options over yaml#5495
Merged
Merged
Conversation
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 10, 2021
ervteng
reviewed
Aug 11, 2021
| opt = parse_command_line(full_args) | ||
| assert opt.checkpoint_settings.initialize_from is None # ignore init if resume set | ||
| assert opt.checkpoint_settings.resume is True | ||
|
|
Contributor
There was a problem hiding this comment.
Do we need a test to check if they were both set in the YAML but not the CLI? I think we can do this in the test_settings.py.
ervteng
approved these changes
Aug 11, 2021
ervteng
approved these changes
Aug 11, 2021
ervteng
left a comment
Contributor
There was a problem hiding this comment.
Forgot in my last approval - add this bug fix to the CHANGELOG.md file and reference the PR before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
steps to reproduce the bug:
solution: checkpointSetting class now prioritize the command line arguments (resume or initialize_from for now) over conflicting yaml options. yaml option is nuke with a warning
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments