Skip to content

Fix stacked grid sensor#5335

Merged
dongruoping merged 3 commits into
mainfrom
fix-stacked-gridsensor
May 3, 2021
Merged

Fix stacked grid sensor#5335
dongruoping merged 3 commits into
mainfrom
fix-stacked-gridsensor

Conversation

@dongruoping

Copy link
Copy Markdown
Contributor

Proposed change(s)

Fix grid sensor with observation stack > 1.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@dongruoping dongruoping requested a review from surfnerd May 3, 2021 17:30
Comment thread com.unity.ml-agents/Runtime/Sensors/GridSensorComponent.cs

@surfnerd surfnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongruoping dongruoping merged commit a7a22f4 into main May 3, 2021
@delete-merged-branch delete-merged-branch Bot deleted the fix-stacked-gridsensor branch May 3, 2021 18:05
dongruoping pushed a commit that referenced this pull request May 3, 2021
dongruoping pushed a commit that referenced this pull request May 3, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants