Skip to content

Fix inference CI timeouts in Match3 and VisualFoodCollector#5298

Merged
chriselion merged 4 commits into
mainfrom
inference-timeouts
Apr 21, 2021
Merged

Fix inference CI timeouts in Match3 and VisualFoodCollector#5298
chriselion merged 4 commits into
mainfrom
inference-timeouts

Conversation

@chriselion

Copy link
Copy Markdown
Contributor

Proposed change(s)

  • Previously, when in inference mode, Match3 would update a sub-step (find matches, remove them, drop, etc) every .25 seconds. In training, it would do all of these steps (until stable) every FixedUpdate. Now in inference, it does this every FixedUpdate if ModelOverrides are enabled.
  • Add ModelOverrides to Agents in VisualFoodCollector

Types of change(s)

  • CI

@vincentpierre vincentpierre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I think we should cherry pick onto the release.

Comment thread Project/Assets/ML-Agents/Examples/SharedAssets/Scripts/ModelOverrider.cs Outdated
@chriselion chriselion merged commit 2fb3825 into main Apr 21, 2021
@delete-merged-branch delete-merged-branch Bot deleted the inference-timeouts branch April 21, 2021 17:37
chriselion pushed a commit that referenced this pull request Apr 21, 2021
* add ModelOverrider to VisualFoodCollector

* use fast stepping when graphics disabled

* match3 - check ModelOverrider instead of graphics

* comments
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants