Add doc for custom GridSensor#5282
Merged
Merged
Conversation
chriselion
approved these changes
Apr 19, 2021
chriselion
left a comment
chriselion
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just not sure if it should go in the extensions documentation or the general docs.
Contributor
Author
Since it mentioned CountingGridSensor and limitations around normalization and compression, I think it would be better to keep in the extension. |
dongruoping
pushed a commit
that referenced
this pull request
Apr 19, 2021
10 tasks
dongruoping
pushed a commit
that referenced
this pull request
Apr 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add documentation for how to derive from GridSensorBase and intro for CountingGridSensor.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments