Skip to content

Fix errors when creating new RayCast sensor#5261

Merged
dongruoping merged 4 commits into
mainfrom
fix-raycast-zero-tags
Apr 14, 2021
Merged

Fix errors when creating new RayCast sensor#5261
dongruoping merged 4 commits into
mainfrom
fix-raycast-zero-tags

Conversation

@dongruoping

Copy link
Copy Markdown
Contributor

Proposed change(s)

If you create an agent, and then add a RayPerceptionSensorComponent, the editor will keep throwing error: NullReferenceException: Object reference not set to an instance of an object

The Agent is trying to get OutputSize while RayPerceptionSensor.DetectableTags/Angles are still null.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note in the changelog too?

@dongruoping dongruoping merged commit 08a66c4 into main Apr 14, 2021
@delete-merged-branch delete-merged-branch Bot deleted the fix-raycast-zero-tags branch April 14, 2021 23:45
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants