Skip to content

Adding the goal conditioning sensors with the new observation specs#5159

Merged
vincentpierre merged 12 commits into
mainfrom
goal-conditioning-sensors-3
Mar 29, 2021
Merged

Adding the goal conditioning sensors with the new observation specs#5159
vincentpierre merged 12 commits into
mainfrom
goal-conditioning-sensors-3

Conversation

@vincentpierre

Copy link
Copy Markdown
Contributor

Proposed change(s)

Adding the goal conditioning sensors with the new observation specs

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre requested a review from awjuliani March 19, 2021 03:00
@vincentpierre vincentpierre self-assigned this Mar 19, 2021
@vincentpierre vincentpierre force-pushed the goal-conditioning-sensors-3 branch from fe49ee0 to 570df7f Compare March 19, 2021 03:04
Comment thread com.unity.ml-agents/Runtime/Sensors/ISensor.cs
Comment thread com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs Outdated
Comment thread com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs Outdated
Comment thread com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs Outdated

@chriselion chriselion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending the feedback.

Comment thread com.unity.ml-agents/Runtime/Sensors/VectorSensor.cs Outdated
Comment thread com.unity.ml-agents/Runtime/Sensors/VectorSensorComponent.cs
@vincentpierre vincentpierre merged commit ca0fca7 into main Mar 29, 2021
@delete-merged-branch delete-merged-branch Bot deleted the goal-conditioning-sensors-3 branch March 29, 2021 18:58
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants