Skip to content

Fix for validate release links script#5100

Merged
ervteng merged 1 commit into
mainfrom
develop-validate-release-fix
Mar 15, 2021
Merged

Fix for validate release links script#5100
ervteng merged 1 commit into
mainfrom
develop-validate-release-fix

Conversation

@ervteng

@ervteng ervteng commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Proposed change(s)

Fixes two minor issues with the validate_release_links script.

  • Don't try to replace when there is no pip install line
  • Match Python versions with more than one digit per number (e.g. X.YY.Z).

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from chriselion March 12, 2021 16:16

@chriselion chriselion left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

@ervteng ervteng merged commit 2073807 into main Mar 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants