Skip to content

Make step in trainer private#5099

Merged
ervteng merged 1 commit into
fix-ghost-currfrom
fix-ghost-curr-2
Mar 12, 2021
Merged

Make step in trainer private#5099
ervteng merged 1 commit into
fix-ghost-currfrom
fix-ghost-curr-2

Conversation

@ervteng

@ervteng ervteng commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

Proposed change(s)

Make step in trainer private. Public method is called get_step()

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng merged commit 35ed23e into fix-ghost-curr Mar 12, 2021
@delete-merged-branch delete-merged-branch Bot deleted the fix-ghost-curr-2 branch March 12, 2021 15:07
andrewcoh added a commit that referenced this pull request Mar 12, 2021
* use get step to determine curriculum

* add to CHANGELOG

* Make step in trainer private (#5099)

Co-authored-by: Ervin T <ervin@unity3d.com>
ervteng pushed a commit that referenced this pull request Mar 12, 2021
* use get step to determine curriculum

* add to CHANGELOG

* Make step in trainer private (#5099)

Co-authored-by: Ervin T <ervin@unity3d.com>
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants