Communicator factory#4965
Merged
Merged
Conversation
chriselion
commented
Feb 18, 2021
| /// Initializes a new instance of the RPCCommunicator class. | ||
| /// </summary> | ||
| /// <param name="communicatorInitParameters">Communicator parameters.</param> | ||
| public RpcCommunicator(CommunicatorInitParameters communicatorInitParameters) |
Contributor
Author
There was a problem hiding this comment.
Don't pass these and don't store them anymore. They were only used for the port; that's now passed to Initialize()
vincentpierre
approved these changes
Feb 18, 2021
vincentpierre
left a comment
vincentpierre
left a comment
Contributor
There was a problem hiding this comment.
How did you test this was working for mobile builds ?
Contributor
Author
|
Manual tested that I can do a WebGL build locally. I have a PR to start doing a WebGL build in yamato to guard against similar compiler errors in the future: #4966 (currently failing because it lacks this fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Follow up for the "RpcCommunicator on non-desktop" compilation problems.
CommunicatorInitParametersin both it's constructor and Initialize() method. It stored the former but only used the port from it.CommunicatorFactory.Enabled = falsewill skip creating (and attempting to connect) with RpcCommunicator. This is a bit clunky but it's the only way we have to avoid trying to connect to a trainer, which could be a problem for shipping games.Types of change(s)
Checklist
Other comments