Develop var len obs feature#4909
Merged
Merged
Conversation
…r-len-obs-feature
…elop-var-len-obs-feature
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
chriselion
approved these changes
Feb 5, 2021
…feature-refactor-model-loader-checks Develop var len obs feature refactor model loader checks
chriselion
reviewed
Feb 5, 2021
| private int m_ObsSize; | ||
| float[] m_ObservationBuffer; | ||
| int m_CurrentNumObservables; | ||
| static DimensionProperty[] m_DimensionProperties = new DimensionProperty[]{ |
Contributor
There was a problem hiding this comment.
nit: s_DimensionProperties
chriselion
reviewed
Feb 5, 2021
| the `BufferSensor` will be able to collect. | ||
|
|
||
| To add an entity's observations to the `BufferSensor`, you need to call the | ||
| `BufferSensor.AppendObservation()` (or `BufferSensorComponent.AppendObservation()`) |
Contributor
There was a problem hiding this comment.
I think this is a little misleading since you can't access the BufferSensor directly (at the moment)
andrewcoh
approved these changes
Feb 10, 2021
Closed
Hunter-Unity
approved these changes
Feb 10, 2021
Hunter-Unity
left a comment
Hunter-Unity
left a comment
Contributor
There was a problem hiding this comment.
pulled the scene. found one issue with buffer sensor obsv size that vince fixed. confirmed his fix resolved the issue. looks good now.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Adding support for variable length observations.
Adding a new environment to test it : Sorter
TODO :
Types of change(s)
[ ] Bug fix- [ ] Code refactor[ ] Breaking change[ ] Other (please describe)Checklist
[ ] Updated the migration guide (if applicable)Other comments