chore: Add DA ConnectionApprovalCallback warnings#3658
Merged
EmandM merged 3 commits intodevelop-2.0.0from Sep 10, 2025
Merged
Conversation
jabbacakes
approved these changes
Sep 9, 2025
NoelStephensUnity
approved these changes
Sep 9, 2025
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
It looks real nice Emma!
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
A post on the discussions board pointed out that we don't have any information around the
ConnectionApprovalCallbackindicating that it won't work with distributed authority.This PR:
StartClient?)Jira ticket
n/a
Changelog
NetworkManager.NetworkConfig.ConnectionApprovalis set in a DA context.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Mostly a docs update, no manual testing is needed.
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
Only a DA issue so 2.x only.
Docs screenshots
Connection Approval:
NetworkConfig settings
NetworkManager start