fix(until): terminate surviving descendants after readiness - #229
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After
--untilmatches, the direct child can exit before a descendant that ignores SIGTERM. The existing fallback watchdog then disarms, leaving the descendant running.This change checks the process group after the direct child is reaped, gives remaining members a short grace period, and sends SIGKILL if the group still exists. It adds an integration test that waits for a descendant to install its SIGTERM handler before printing
READY, then verifies that it cannot continue running.Closes #79.
Verification
cargo test --locked --test until_tests(9 passed)cargo clippy --locked --all-targets -- -D warningscargo fmtAntigravity drafted the initial patch in an isolated worktree; I reviewed it, strengthened the regression test, and ran the checks above.