Repository navigation
fix(dev): move the node service to 22, and say so in package.json (#101) - #103
Merged
Merged
Conversation
Closes #101. docker-compose pinned node:20-alpine and the frontend suite needs 22.15. On Node 20, tests/Frontend/vue-loader.js dies at import -- module.registerHooks() does not exist there -- and features.test.js goes with it. Measured: node:20 # tests 15 # pass 14 # fail 1 node:22 # tests 26 # pass 26 # fail 0 Eleven tests missing, and `node --test` reports one failed file rather than eleven absent tests. The total changes too, so nothing looks wrong unless you already know the number. CI has been on 22 since #81 and is green at 26/26, which is exactly the split worth closing: a developer running `docker compose --profile dev up` saw fourteen passing and had no reason to doubt it. engines.node makes npm say so at install time, rather than leaving a vanished test to be the signal. Verified on node:22-alpine, the image the compose file now uses: 26/26. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pvf2R8xtgbWQm1wRvjBqQY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fecha a #101.
O
docker-composefixavanode:20-alpinee a suíte de frontend precisa de 22.15. No Node 20 otests/Frontend/vue-loader.jsmorre no import —module.registerHooks()não existe lá — e ofeatures.test.jsvai junto.Medido:
Onze testes a menos, e o
node --testreporta um arquivo com falha, não onze testes ausentes. O total muda junto, então nada parece errado a menos que você já saiba o número.O CI está no 22 desde a #81 e verde em 26/26 — que é exatamente a divisão que valia fechar: quem rodava
docker compose --profile dev upvia catorze passando e não tinha motivo nenhum para desconfiar.O
engines.nodefaz o npm avisar na instalação, em vez de deixar um teste sumido ser o sinal.Verificado em
node:22-alpine, a imagem que o compose passa a usar: 26/26.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pvf2R8xtgbWQm1wRvjBqQY