Skip to content

feat: [ListV2] Add extra bottom padding to collection assets#5930

Merged
cbachmeier merged 1 commit into
mainfrom
cab/v2_bottomPadding
Feb 6, 2023
Merged

feat: [ListV2] Add extra bottom padding to collection assets#5930
cbachmeier merged 1 commit into
mainfrom
cab/v2_bottomPadding

Conversation

@cbachmeier
Copy link
Copy Markdown
Contributor

Add extra bottom padding to the grid of NFT's being listed. Prevents issue where listing multiple the bottom row would be covered by the bar

Before
Screen Shot 2023-02-06 at 10 02 59
After
Screen Shot 2023-02-06 at 10 02 49

@cbachmeier cbachmeier requested a review from JackShort February 6, 2023 18:05
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
interface ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 6:07PM (UTC)

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 12.86% // Head: 12.86% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1ca2a00) compared to base (ae4135f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5930      +/-   ##
==========================================
- Coverage   12.86%   12.86%   -0.01%     
==========================================
  Files         408      408              
  Lines       12815    12816       +1     
  Branches     4491     4492       +1     
==========================================
  Hits         1649     1649              
- Misses      11159    11160       +1     
  Partials        7        7              
Impacted Files Coverage Δ
src/components/Button/index.tsx 26.78% <0.00%> (-0.17%) ⬇️
src/pages/Vote/Landing.tsx 0.00% <0.00%> (ø)
src/pages/Pool/PositionPage.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@JackShort JackShort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbachmeier cbachmeier merged commit 8f922b6 into main Feb 6, 2023
@cbachmeier cbachmeier deleted the cab/v2_bottomPadding branch February 6, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants