refactor: Improve A11y

[mdmellis]

This pull request aims to enhance the accessibility of the Uniswap interface web application by addressing the opportunities identified in a recent Lighthouse a11y audit. The changes made result in an improvement of the lighthouse a11y score from 77/100 to 92/100, representing a 15% increase. These improvements will contribute to a more inclusive user experience for all users.

• The addition of SVG titles to the Discord and Twitter buttons to improve navigation experience for screen reader users.
• The addition of aria labels to the chevron, magnifying glass, and ellipsis icon buttons to provide accessible names for screen readers.
• The removal of a reused id from the "pool" button to ensure all focusable buttons have a unique id.
• The modification of an h3 element to a div element to maintain proper heading hierarchy.
• The updating of integration tests to reflect the changes made.

Before:

After:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
interface	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 2, 2023 at 6:41PM (UTC)

[zzmp]

Thank you @mdmellis! These changes look great, and I'm glad you're giving some attention to a11y 😄.

There are a few small changes to make for translations to be properly supported, and I've tried to give you sample code for all of them. If I don't hear back from you in a day or two, I can still merge this in as-is and I can make those changes as a follow-up. Thanks again!

[mdmellis]

@zzmp thanks for the feedback. I appreciate it. I implemented changes as requested. Let me know if anything else is needed.

[mdmellis]

@zzmp I made the changes requested. Thanks again for the feedback. It looks like the vercel step failed but I'm unable to access the link to debug. What can I do to enable the vercel deploy step?

[zzmp]

You're getting a typescript error on compilation, which is blocking vercel from completing.
I think it will resolve if you just merge main into your branch - could you try that?

[mdmellis]

@zzmp looks like that did the trick. Thank you for the guidance. It appears that a workflow needs to be approved. Are you able to assist with this?

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (e8c689e) 13.65% compared to head (636daca) 13.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5913      +/-   ##
==========================================
- Coverage   13.65%   13.65%   -0.01%     
==========================================
  Files         411      411              
  Lines       12915    12918       +3     
  Branches     4532     4536       +4     
==========================================
  Hits         1764     1764              
- Misses      11143    11145       +2     
- Partials        8        9       +1     

Impacted Files	Coverage Δ
src/components/NavBar/MenuDropdown.tsx	0.00% <0.00%> (ø)
src/components/NavBar/NavIcon.tsx	0.00% <0.00%> (ø)
src/components/NavBar/SearchBar.tsx	0.00% <0.00%> (ø)
src/components/NavBar/index.tsx	0.00% <ø> (ø)
src/components/Web3Status/index.tsx	0.00% <0.00%> (ø)
src/pages/Landing/index.tsx	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.