fix: adding usd_value back to trace event#5912
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
d41c2f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9a33f138.interface-y3o.pages.dev |
| Branch Preview URL: | https://jack-traceevent.interface-y3o.pages.dev |
cbachmeier
approved these changes
Feb 2, 2023
Contributor
cbachmeier
left a comment
cbachmeier
left a comment
There was a problem hiding this comment.
LGTM non-blocking suggestion
| const usdcValue = useStablecoinValue(inputCurrency ? swapTrade?.inputAmount : parsedAmount) | ||
| const traceEventProperties = { | ||
| usd_value: usdcValue?.toExact(), | ||
| ...eventProperties, |
Contributor
There was a problem hiding this comment.
The past in eventsProperty is instantiated in Bag but only ever passed down. To reduce BagFooter args you could instantiate here and include the usd_value
Contributor
Author
There was a problem hiding this comment.
actually it still needs to be passed down because the other event properties come from the items in the bag that aren't being passed to the footer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usd_valueadding it back