fix: colors in token warnings#5787
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cartcrom
approved these changes
Jan 4, 2023
Contributor
cartcrom
left a comment
cartcrom
left a comment
There was a problem hiding this comment.
Looks great! Appreciate the tests and refactors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://uniswaplabs.atlassian.net/browse/WEB-1612?atlOrigin=eyJpIjoiYTgxYTE1MWU5ZjcyNDI5NWIwNTA0OTI0MzlhZGE1ZGMiLCJwIjoiaiJ9
updates the token warnings to use the correct colors matching design spec: https://www.figma.com/file/kNSDBMpOzxSTOP6MerohLm/Web-Design-Spec?node-id=8031%3A95901&t=KxoNn01mFw7AgQDh-0
also, updates the hooks for getting the colors so that we're not unnecessarily storing the colors in state variables.
and adds some unit tests for these hooks.