chore: Migrate The Graph queries by cbachmeier · Pull Request #5727 · Uniswap/interface

cbachmeier · 2022-12-19T19:39:23Z

Migrate Pooled data queries from Relay to Apollo. Similar to how we previously had two different RelayEnvironments, I set up two Apollo clients. I also setup some middleware to dynamically update the uri for the requests. This was tested locally by creating pool positions and switching chains.

vercel · 2022-12-19T19:39:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
interface	✅ Ready (Inspect)	Visit Preview	Dec 20, 2022 at 2:12AM (UTC)

cloudflare-workers-and-pages · 2022-12-19T19:43:44Z

Deploying with Cloudflare Pages

Latest commit:	`aae33b6`
Status:	✅ Deploy successful!
Preview URL:	https://93192a10.interface-y3o.pages.dev
Branch Preview URL:	https://web-2584-handle-the-graph-qu.interface-y3o.pages.dev

View logs

justindomingue · 2022-12-19T22:10:14Z

+      skip,
+    },
+    pollInterval: interval,
+    client: apolloClient,


longer term, is there a way to share the client?

I think there is a way by leveraging more middleware but it seems like the long term solution will be using our own endpoint which handles different chains. So I don't want to over invest in a more elegant solution if it would be thrown away https://uniswapteam.slack.com/archives/C02T729PMQE/p1671469080701009

justindomingue · 2022-12-19T22:19:57Z

+    uri:
+      chainId && CHAIN_SUBGRAPH_URL[chainId]
+        ? CHAIN_SUBGRAPH_URL[chainId]
+        : CHAIN_SUBGRAPH_URL[SupportedChainId.MAINNET],


would this behave incorrectly if subgraph isn't defined for chain? should we throw?

alternatively you may be able to narrow the type of CHAIN_SUBGRAPH_URL with ts, as const

const CHAIN_SUBGRAPH_URL = { [SupportedChainId.MAINNET]: 'https://api.thegraph.com/subgraphs/name/uniswap/uniswap-v3', [SupportedChainId.RINKEBY]: 'https://api.thegraph.com/subgraphs/name/uniswap/uniswap-v3', ... } as const

i think CHAIN_SUBGRAPH_URL[chainId] will never be undefined then

This logic always falls back to Mainnet's chain. I also don't want to invest into changes to this logic if the long term plan is to rely on are in-house graphql data endpoint

justindomingue · 2022-12-19T22:20:36Z

-
-  useInterval(refreshData, interval, true)
-  return { error, isLoading, data }
+  return useMemo(


nit. don't think you need to memo this one since data, loading and error should be stable from apollo

It has come about to make the standard practice for all our graphql queries to memoize the return data so while it might be stable I do like keeping with the standard personally

I thought you were doing it to rename loading to isLoading

zzmp · 2022-12-20T00:43:41Z

@@ -1,3 +1,4 @@
 *.config.ts
 *.d.ts
 /src/graphql/data/__generated__/types-and-hooks.ts


this should be given a better name than data, to contrast with thegraph.

uniswap? Since it uses the Uniswap endpoint? Also I would prefer to refactor this after migrating to best keep changes localized to Relay -> Apollo

I think uniswap makes sense. Also, fine to defer, I think avoiding scope creep is good here.

zzmp · 2022-12-20T01:47:35Z

-
-  useInterval(refreshData, interval, true)
-  return { error, isLoading, data }
+  return useMemo(


I thought you were doing it to rename loading to isLoading

* feat: initial apollo configutation (#5565) * initial apollo configutation * add new files * check in types-and-hooks * config unused export * deduplicate * ignore checked in schema for linting * remove prettier ignore * test unchecking types and hooks file * undo * rename codegen, respond to comments Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * Remove maybe value from codegen * add babel gql codegen * correct ts graphql-tag * remove plugin from craco * chore: migrate Assets Query to Apollo (#5665) * chore: migrate Assets Query to Apollo * delete comment * move length check back to collectionAssets * remove uneeded check * respond to comments * working switching and filters * change sweep fetch policy Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * chore: migrate collection query to apollo (#5647) * migrate collection query to apollo * remove page level suspense * undo removing page level suspense * rename query and hook * guard returns * add return type prop * cleanup nullables * memoizing * use gql from apollo * use babel gql and move empty trait * add fetch policy Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * chore: migrate NFT details query to apollo (#5648) * chore: migrate NFT details query to apollo * update todo * update imports * remove no longer used hook * rename query * use babel gql and nonnullable type * working page * add fetchpolicy * respond to comments Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * chore: migrate NftBalanceQuery (#5653) * chore: migrate NftBalanceQuery * cleanup * update pagination * better undefined handling * move brake listing for invalid asset higher * better handle loading * memoize and cleanup Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * remove named gql query consts * set default fetchPolicy * null suspense * chore: Migrate The Graph queries (#5727) * migrate TheGraph queries to Apollo * add new files * ignore thegraph generated types * use standard fetchPolicy * update apollo codegen commands Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * chore: migrate token queries to Apollo (#5682) * migrate utils to types-and-hooks * too many TokenTable re-renders * working token queries * fixed sparkline for native asset * onChangeTimePeriod * define inline * use query instead of data in naming * sparklineQuery instead of sparklineData * rename to usePriceHistory * multiline if else * remove optional * remove unneeded eslint ignore * rename tokenQueryLoading * rename OnChangeTimePeriod * token address fallback * just address Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * chore: deprecate Relay (#5747) * chore: deprecate Relay * remove graph:ql generate step * add new files * apollo to graphql centric naming * add new files Co-authored-by: Charles Bachmeier <charlie@genie.xyz> * remove no longer needed config exclusions Co-authored-by: Charles Bachmeier <charlie@genie.xyz>

Charles Bachmeier added 2 commits December 19, 2022 11:35

migrate TheGraph queries to Apollo

09f80fd

add new files

8ef1bd4

cbachmeier requested review from ianlapham, justindomingue, vm and zzmp December 19, 2022 19:39

vercel Bot deployed to Preview December 19, 2022 19:44 View deployment

cbachmeier requested review from grabbou and removed request for vm December 19, 2022 19:48

ignore thegraph generated types

aa8a920

vercel Bot deployed to Preview December 19, 2022 22:07 View deployment

justindomingue reviewed Dec 19, 2022

View reviewed changes

cbachmeier requested a review from justindomingue December 19, 2022 22:18

justindomingue reviewed Dec 19, 2022

View reviewed changes

justindomingue approved these changes Dec 19, 2022

View reviewed changes

Charles Bachmeier added 2 commits December 19, 2022 15:03

Merge branch 'apollo_migration' into WEB-2584-handle-the-graph-queries

e7ccb0c

use standard fetchPolicy

2b40311

vercel Bot deployed to Preview December 19, 2022 23:18 View deployment

zzmp suggested changes Dec 20, 2022

View reviewed changes

update apollo codegen commands

aae33b6

cbachmeier requested a review from zzmp December 20, 2022 02:04

vercel Bot deployed to Preview December 20, 2022 02:12 View deployment

zzmp approved these changes Dec 20, 2022

View reviewed changes

cbachmeier merged commit 66949c2 into apollo_migration Dec 20, 2022

cbachmeier deleted the WEB-2584-handle-the-graph-queries branch December 20, 2022 16:20

cbachmeier mentioned this pull request Dec 20, 2022

chore: Migrate from Relay to Apollo #5754

Merged

Conversation

cbachmeier commented Dec 19, 2022

Uh oh!

vercel Bot commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cloudflare-workers-and-pages Bot commented Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cbachmeier Dec 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Dec 19, 2022 •

edited

Loading

cloudflare-workers-and-pages Bot commented Dec 19, 2022 •

edited

Loading

cbachmeier Dec 19, 2022 •

edited

Loading