[8주차/썽아] 워크북 제출합니다.#24
Merged
Merged
Conversation
jiyoung02
approved these changes
Nov 25, 2025
jiyoung02
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 수고하셨습니다 😊
코드상으로 확인했을 때 전반적인 구현이 정말 잘 되어 있습니다!
다만 현재 google-services.json 파일이 누락되어 있어 빌드가 불가능한 상태입니다.
이로 인해 기능 테스트를 진행하기 어려운 점 양해 부탁드립니다 😭
보안상 일반적으로 해당 파일은 업로드하지 않는 것이 맞지만,
이번 실습 프로젝트의 특성상 예외적으로 google-services.json을 깃허브에 업로드 부탁드립니다.
디테일한 코드 리뷰는 9주차에 한 번에 정리해서 남겨드리도록 하겠습니다 :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 워크북 체크리스트
✅ 컨벤션 체크리스트
📌 주안점