Skip to content

Warm up system playlists if they report themselves unavailable on the first request - #855

Merged
Tyrrrz merged 2 commits into
masterfrom
warm-up-playlists
Dec 30, 2024
Merged

Tyrrrz merged 2 commits into
masterfrom
warm-up-playlists

Conversation

@Tyrrrz

@Tyrrrz Tyrrrz commented Dec 30, 2024

Copy link
Copy Markdown
Owner

Related to #854

@Tyrrrz
Tyrrrz requested a review from Copilot December 30, 2024 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

YoutubeExplode/Playlists/PlaylistController.cs:108

  • [nitpick] The condition 'retriesRemaining >= 5' seems arbitrary. Consider making the retry count configurable or document why this specific number was chosen.
if (index <= 0 && string.IsNullOrWhiteSpace(visitorData) && retriesRemaining >= 5)

YoutubeExplode/Playlists/PlaylistController.cs:106

  • [nitpick] The comment could be clearer. Mention that the retry mechanism is specifically for warming up system playlists.
// Some system playlists are unavailable through this endpoint until their page is opened by

@Tyrrrz
Tyrrrz requested a review from Copilot December 30, 2024 11:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Tyrrrz
Tyrrrz merged commit 8ba5671 into master Dec 30, 2024
@codecov

codecov Bot commented Dec 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (30ba3f2) to head (a069f6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff      @@
##   master   #855   +/-   ##
=============================
=============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants