Fix (ReadOnly)Span.Contains with System.Memory NuGet Package#72
Closed
GerardSmit wants to merge 3 commits into
Closed
Fix (ReadOnly)Span.Contains with System.Memory NuGet Package#72GerardSmit wants to merge 3 commits into
GerardSmit wants to merge 3 commits into
Conversation
GerardSmit
changed the title
GerardSmit
force-pushed
the
fix/memory-extensions
branch
from
ded03f9 to
4dbdcf6
Compare
GerardSmit
force-pushed
the
fix/memory-extensions
branch
from
4dbdcf6 to
73a55a4
Compare
GerardSmit
commented
Jan 21, 2026
|
|
||
| // https://learn.microsoft.com/dotnet/api/system.memoryextensions.asspan#system-memoryextensions-asspan-1(-0()-system-int32) | ||
| public Span<T> AsSpan(int start) => array.AsSpan(start, array?.Length ?? 0 - start); | ||
| public Span<T> AsSpan(int start) => array.AsSpan(start, (array?.Length ?? 0) - start); |
Author
There was a problem hiding this comment.
This a bug fix.
Before the compile would do the following: array?.Length ?? (0 - start)
Instead of: (array?.Length ?? 0) - start
Do you want me to lift this to another PR?
Owner
|
Superseded by #74 |
Tyrrrz
added
duplicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
#if-directives soContainsis added.I need to check the new lines, since there is no.editorconfigin this repo, always fun the differences between Windows, Linux and Git configuration 😅