Add polyfill for Dictionary<TKey, TValue>.TryAdd(...)#52
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a polyfill for the Dictionary<TKey, TValue>.TryAdd(TKey key, TValue value) method, which was introduced in .NET Core 2.0. The polyfill enables this functionality for earlier framework versions including .NET Core 1.x, all versions of .NET Framework, and .NET Standard versions prior to 2.1.
- Implements
TryAddusing the check-then-add pattern viaContainsKeyandAdd - Updates the signature documentation and count metadata
- Enhances the PowerShell signature extraction script to handle generic constraints
- Provides comprehensive test coverage for both success and failure scenarios
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PolyShim/NetCore20/Dictionary.cs | Adds the TryAdd extension method polyfill with proper generic constraints matching the native API |
| PolyShim/Signatures.md | Documents the new Dictionary.TryAdd member and updates total signature counts |
| PolyShim/List-Signatures.ps1 | Updates regex pattern to correctly parse extension methods with generic where clauses |
| PolyShim.Tests/NetCore20/DictionaryTests.cs | Adds test coverage for TryAdd with scenarios for both new keys and duplicate keys |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 1, 2025
This was referenced Jan 1, 2026
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.