Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds polyfills for Math.Clamp(...) to enable this API on older .NET framework versions.
- Adds generic
Math.Clamp<T>polyfill for frameworks before .NET Core 2.0 - Adds
Math.ClampforIntPtr(nint) for frameworks before .NET 6.0 - Includes test coverage for both polyfill implementations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PolyShim/NetCore20/Math.cs | Implements generic Math.Clamp<T> polyfill using IComparable<T> for frameworks lacking .NET Core 2.0 APIs |
| PolyShim/Net60/Math.cs | Implements Math.Clamp for IntPtr/nint type for frameworks lacking .NET 6.0 APIs |
| PolyShim.Tests/NetCore20/MathTests.cs | Adds tests for generic clamp implementation covering integer and double types |
| PolyShim.Tests/Net60/MathTests.cs | Adds tests for IntPtr clamp implementation covering basic clamping scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Dec 1, 2025
This was referenced Jan 1, 2026
This was referenced Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.