Skip to content

Add polyfill for string.IsNullOrWhiteSpace(...)#28

Merged
Tyrrrz merged 1 commit into
masterfrom
is-null-whitespace
Nov 15, 2025
Merged

Add polyfill for string.IsNullOrWhiteSpace(...)#28
Tyrrrz merged 1 commit into
masterfrom
is-null-whitespace

Conversation

@Tyrrrz

@Tyrrrz Tyrrrz commented Nov 15, 2025

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings November 15, 2025 15:19
@Tyrrrz Tyrrrz added the enhancement New feature or request label Nov 15, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a polyfill for string.IsNullOrWhiteSpace(...) to support .NET Framework versions prior to 4.0 (such as .NET Framework 3.5), where this method was not yet available. The implementation follows the existing polyfill pattern used throughout the codebase.

Key Changes:

  • Added String.cs polyfill in the NetCore10 directory with conditional compilation for pre-.NET 4.0 frameworks
  • Implemented IsNullOrWhiteSpace as a static extension method that checks for null or whitespace-only strings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PolyShim/NetCore10/String.cs
Comment thread PolyShim/NetCore10/String.cs
@Tyrrrz Tyrrrz merged commit a51d451 into master Nov 15, 2025
11 checks passed
@Tyrrrz Tyrrrz deleted the is-null-whitespace branch November 15, 2025 15:25
@codecov

codecov Bot commented Nov 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (34464d9) to head (6eefbb2).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@     Coverage Diff      @@
##   master   #28   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants