Skip to content

feat(ssh)!: Rename ssh.ca.manual config to ssh.ca.local - #489

Open
minhtule wants to merge 1 commit into
masterfrom
feat/mt/rename-ssh-ca-config
Open

feat(ssh)!: Rename ssh.ca.manual config to ssh.ca.local#489
minhtule wants to merge 1 commit into
masterfrom
feat/mt/rename-ssh-ca-config

Conversation

@minhtule

@minhtule minhtule commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

⚠️ This is a schema breaking change for config.yaml.

Changes

Rename "manual CA" to "local CA" for SSH config to be consistent with local issuer for TLS in #423

@codecov

codecov Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.64%. Comparing base (f2b4f92) to head (c06ba4c).
⚠️ Report is 15 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   93.68%   93.64%   -0.04%     
==========================================
  Files          42       42              
  Lines        2659     2659              
==========================================
- Hits         2491     2490       -1     
- Misses        167      168       +1     
  Partials        1        1              
Flag Coverage Δ
integration 64.90% <45.45%> (ø)
unit 88.60% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/config/config.go 94.23% <100.00%> (ø)
internal/sshhandler/ca.go 97.50% <100.00%> (ø)
internal/sshhandler/key_reloader.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the SSH CA mode from manual to local across Go configuration, Helm resources, tests, and documentation.

Changes:

  • Renames the SSH configuration schema and implementation types.
  • Updates Helm values, templates, resource names, and snapshots.
  • Updates unit, integration, and local-development fixtures.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/local/main.go Uses the ssh.ca.local configuration.
test/integration/ssh_test.go Updates integration fixtures to the local CA type.
internal/sshhandler/proxy_test.go Updates proxy test setup and terminology.
internal/sshhandler/key_reloader.go Generalizes key-reload documentation and logging.
internal/sshhandler/config_test.go Renames local CA configuration tests.
internal/sshhandler/ca.go Renames the CA provider and constructor.
internal/sshhandler/ca_test.go Updates CA provider tests.
internal/proxy/proxy_test.go Updates the complete proxy configuration fixture.
internal/config/config.go Introduces the breaking local configuration schema.
internal/config/config_test.go Tests loading and validating the renamed schema.
deploy/gateway/values.yaml Documents the Helm local CA values.
deploy/gateway/values.schema.json Validates local instead of manual.
deploy/gateway/tests/ssh-local-ca-secret_test.yaml Tests local CA Secret rendering.
deploy/gateway/tests/snapshot_test.yaml Updates snapshot input values.
deploy/gateway/tests/gateway-configmap_test.yaml Tests local CA ConfigMap output.
deploy/gateway/tests/deployment_test.yaml Tests renamed volumes and Secrets.
deploy/gateway/tests/__snapshot__/snapshot_test.yaml.snap Updates rendered Helm snapshots.
deploy/gateway/templates/ssh-manual-ca-secret.yaml Removes the obsolete manual CA template.
deploy/gateway/templates/ssh-local-ca-secret.yaml Adds the renamed local CA Secret template.
deploy/gateway/templates/gateway-configmap.yaml Emits ssh.ca.local.
deploy/gateway/templates/deployment.yaml Uses local CA volume and Secret names.
deploy/gateway/templates/_helpers.tpl Renames the Secret-name helper.
CLAUDE.md Updates architectural terminology.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@minhtule
minhtule marked this pull request as ready for review September 2, 2026 04:03
@minhtule
minhtule requested a review from clement0010 September 2, 2026 04:03

@clement0010 clement0010 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants