feat(ssh)!: Rename ssh.ca.manual config to ssh.ca.local - #489
Open
minhtule wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #489 +/- ##
==========================================
- Coverage 93.68% 93.64% -0.04%
==========================================
Files 42 42
Lines 2659 2659
==========================================
- Hits 2491 2490 -1
- Misses 167 168 +1
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the SSH CA mode from manual to local across Go configuration, Helm resources, tests, and documentation.
Changes:
- Renames the SSH configuration schema and implementation types.
- Updates Helm values, templates, resource names, and snapshots.
- Updates unit, integration, and local-development fixtures.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tools/local/main.go |
Uses the ssh.ca.local configuration. |
test/integration/ssh_test.go |
Updates integration fixtures to the local CA type. |
internal/sshhandler/proxy_test.go |
Updates proxy test setup and terminology. |
internal/sshhandler/key_reloader.go |
Generalizes key-reload documentation and logging. |
internal/sshhandler/config_test.go |
Renames local CA configuration tests. |
internal/sshhandler/ca.go |
Renames the CA provider and constructor. |
internal/sshhandler/ca_test.go |
Updates CA provider tests. |
internal/proxy/proxy_test.go |
Updates the complete proxy configuration fixture. |
internal/config/config.go |
Introduces the breaking local configuration schema. |
internal/config/config_test.go |
Tests loading and validating the renamed schema. |
deploy/gateway/values.yaml |
Documents the Helm local CA values. |
deploy/gateway/values.schema.json |
Validates local instead of manual. |
deploy/gateway/tests/ssh-local-ca-secret_test.yaml |
Tests local CA Secret rendering. |
deploy/gateway/tests/snapshot_test.yaml |
Updates snapshot input values. |
deploy/gateway/tests/gateway-configmap_test.yaml |
Tests local CA ConfigMap output. |
deploy/gateway/tests/deployment_test.yaml |
Tests renamed volumes and Secrets. |
deploy/gateway/tests/__snapshot__/snapshot_test.yaml.snap |
Updates rendered Helm snapshots. |
deploy/gateway/templates/ssh-manual-ca-secret.yaml |
Removes the obsolete manual CA template. |
deploy/gateway/templates/ssh-local-ca-secret.yaml |
Adds the renamed local CA Secret template. |
deploy/gateway/templates/gateway-configmap.yaml |
Emits ssh.ca.local. |
deploy/gateway/templates/deployment.yaml |
Uses local CA volume and Secret names. |
deploy/gateway/templates/_helpers.tpl |
Renames the Secret-name helper. |
CLAUDE.md |
Updates architectural terminology. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
minhtule
marked this pull request as ready for review
September 2, 2026 04:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
config.yaml.Changes
Rename "manual CA" to "local CA" for SSH config to be consistent with local issuer for TLS in #423