feat(js-sdk): TurboQuote payments (pay link, status, connection, webhook) - #35
Draft
nicolasiscoding wants to merge 3 commits into
Draft
feat(js-sdk): TurboQuote payments (pay link, status, connection, webhook)#35nicolasiscoding wants to merge 3 commits into
nicolasiscoding wants to merge 3 commits into
Conversation
[js-sdk] Add TurboQuote payment methods + types
- TurboQuote.createPaymentLink(quoteId, { buyerEmail? }) -> { checkoutUrl, paymentId }
- TurboQuote.getPaymentStatus(quoteId) -> status/amount/currency/...
- TurboQuote.getPaymentConnectionStatus() -> connected/charges/payouts + capabilities
- types/quote-payment.ts (incl. QuotePaymentEvents + QuotePaymentSucceededPayload
for the quote.payment.succeeded webhook)
- Reads the backend's { data: { results } } envelope.
- Tests: 5 (mocked HttpClient); full suite 263/263. Port to the other 5 SDKs after.
[js-sdk] E2E test bed (Approach A) for the payments chain - e2e/turboquote-payments.e2e.test.ts: SDK getPaymentConnectionStatus → createPaymentLink → getPaymentStatus(pending) → sign+POST a checkout.session.completed to the backend (Stripe's card capture is bot-blocked, so we feed the provider event ourselves) → getPaymentStatus(paid). - Guarded by E2E_* env (api key OR access token); describe.skip without it, so npm test stays hermetic. jest.e2e.config.js + 'npm run test:e2e'.
This was referenced Jun 12, 2026
nicolasiscoding
pushed a commit
that referenced
this pull request
Jul 29, 2026
…ns (#50) Resolves all 6 open high-severity Dependabot alerts in this repo: | Package | Alerts | Was | Now | Advisory | |-----------------|----------|---------|---------|---------------------| | brace-expansion | #17, #35 | 1.1.12 | 1.1.16 | GHSA-3jxr-9vmj-r5cp | | js-yaml | #18, #36 | 3.14.2 | 3.15.0 | GHSA-52cp-r559-cp3m | | minimatch | #3, #21 | 3.1.2 | 3.1.5 | GHSA-7r86-cg39-jmmj | Each alert is filed twice, once per lockfile (root and packages/js-sdk), so both lockfiles are updated. All three are dev-only transitive dependencies of the Jest/ts-jest test toolchain — none is a direct dependency, none appears in any package.json, and the JS SDK has zero runtime dependencies, so nothing here ships to consumers. No manifest change was needed: every patched version already satisfies the existing semver range its consumers declare (minimatch ^3.1.1, brace-expansion ^1.1.x, js-yaml ^3.13.x), so a plain `npm update` resolves them. No `overrides` pin is used, which keeps future patch releases flowing normally. Verified: `npm ci`, `npm run build:js` (tsc), and `npm run test:js` (271/271 tests) all pass. Co-authored-by: yacineKahlerras <kahlerasse@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the TurboQuote online payments surface to the JS SDK (Stripe Connect today, provider-agnostic shape). Sellers connect a provider once, then generate a hosted pay link, track payment status, check collection readiness, and consume the TurboDocx-native
quote.payment.succeededwebhook.Methods
TurboQuote.getPaymentConnectionStatus()— is the org set up to collect? + providercapabilitiesTurboQuote.createPaymentLink(quoteId, { buyerEmail? })— hosted checkout URL + stablepaymentIdTurboQuote.getPaymentStatus(quoteId)— latest payment status (none|pending|partial|paid|failed|overdue)QuotePaymentLink,QuotePaymentStatus,QuotePaymentConnectionStatus,PaymentProviderCapabilities,QuotePaymentEvents,QuotePaymentSucceededPayloadTests / verification
tests/quote-payment.test.ts(mock HttpClient) — full suite 263/263 green.e2e/turboquote-payments.e2e.test.ts(guarded byE2E_*env).examples/turboquote-payments.ts— verified green end-to-end against a live backend + Stripe sandbox: connection → pay link (realcs_test_…Checkout URL) →pendingstatus →quote.payment.succeededsignature-verify. Webhook envelope shape verified against backendWebhookService.WebhookPayload({ event, event_id, created_at, version, data }).Related
quote-javascript.mdPayments sectionOnline paymentssection + eval test(partner): partner webhook provisioning test suites across SDKs (WIP) #29Notes
Pre-Review Checklist
anyin public interfaces