Repository navigation
Pull requests: unnamed ⋯ triggers, dropdown triggers without a press action, and menus without touch rows #716
Description
Accessibility and touch leftovers on the delivered PR surfaces, found by the #689 and A6 reviews:
- the row and detail ⋯ trigger buttons have only a tooltip, no accessible name; the stack map's "?" (About GitHub stacks) button is unnamed;
- gpui-base dropdown/popover triggers ("Actions for chore(deps): bump gpui-wry from 0.6.0 to 0.6.1 #414", the "Stack ci: build macOS releases on macos-26 runners, realign traffic-light insets #57…" selector on desktop) expose no press action because the click lives on the popover wrapper (the phone bottom-sheet triggers were fixed in fix(ui): phone pull request surfaces #689 at widgets::Popover; the desktop path is gpui-base's Popover);
- the behind chip's Update branch dropdown has no icons and no 44pt rows on touch; the phone row long-press context menu has no
.touch.
Owner: crates/ui/src/pull_requests/{mod,detail,stack}.rs for the names and menus; widgets::Popover / gpui-base for the press action (Principle 6: fix at the owner, report upstream if it is gpui-base's).
Activity
Tryanks commentedon Oct 11, 2026
Status from the fix on branch
ui/tabs-and-consistency:Done in Tcode: accessible names for the row and detail ⋯ triggers and the stack map "?" button, icons and 44pt touch rows on the Update branch dropdown,
.touchon the phone row context menu.Carried (Principle 8): the desktop dropdown triggers still expose no press action. The cause is in gpui-base 0.7.1's own
Popover, not in Tcode's wrapper:gpui-base-0.7.1/src/popover.rs:232–239(Popover::trigger) and:245–249(trigger_with) only hand the trigger its open state; no activation callback is installed on the trigger element.:320wraps the trigger in the enclosingPopup, and:328–345attach Confirm and the mouse-down toggle to that wrapper (:335), so the named trigger button itself never gets an accessibility Click action.Tcode delegates to exactly that path at
crates/ui/src/widgets/popover.rs:158–170andwidgets/menu.rs:439–451; the phone bottom-sheet path has its own press action and is unaffected. Mouse and keyboard activation work; only assistive activation of the named button lacks the action. Left for the maintainer to decide whether to report upstream.feat(ui): one tab bar, one choice control, one input geometry (#720)