Skip to content

Settings: input placeholders and the window title keep the previous language until restart #685

Description

@Tryanks

Found while verifying #645 (fix in #684, which covers the Orchestrate panel only). Switching the UI language in Settings calls apply_locale and window.refresh(), so any string resolved once at construction stays in the old language:

  • Input placeholders set at construction: settings_page.rs (home URL, device name: "我的设备" stays after switching to English), source_control_settings.rs (formerly github_settings.rs), plugins_settings.rs, acp_panel.rs, remote/hosting.rs, among others.
  • The OS window title ("新建对话") stays in the previous language.

Expected: every panel follows the current language without restart, as the composer does (it compares the applied placeholder with the current translation at render and calls set_placeholder), and the window title is set again when the locale changes. Owner: each panel for its placeholders; the shell for the window title. Same mechanism as #645; one PR can sweep the placeholders if the composer's idiom is used everywhere.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions