build: Support docker to build binary package#1112
Merged
kewde merged 1 commit intoTryGhost:masterfrom Feb 4, 2019
Merged
Conversation
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 27, 2019
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Closed
kewde
approved these changes
Jan 27, 2019
Collaborator
kewde
left a comment
kewde
left a comment
There was a problem hiding this comment.
The PR is sound, some nitpicks.
I think the .dockerignore could probably be a lot more lightweight?
.dockerignore
Outdated
| # Build artifacts | ||
| /build | ||
| node_modules/ | ||
| static/js/lib/stm_web.min.js |
.dockerignore
Outdated
| # Run-time artifacts | ||
| .node-persist/ | ||
| config/local.js | ||
| static/uploads |
Collaborator
There was a problem hiding this comment.
Same with some of these artifacts?
Collaborator
|
@rzr Thank you for the contributions. |
kewde
reviewed
Jan 27, 2019
kewde
reviewed
Jan 27, 2019
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
cb805d1 to
b59ad31
Compare
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 28, 2019
This can be then declined for several arch Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jan 28, 2019
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
Usage: ``` docker build . ``` This can be then declined for several arch, elsewhere. Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
force-pushed
the
sandbox/rzr/review/master
branch
from
b59ad31 to
4d19c57
Compare
Collaborator
|
Thank you @rzr |
|
Now that this is merged what's the next step? How do you use this? My ultimate goal is #418. |
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Sep 30, 2019
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jul 1, 2020
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr
added a commit
to CrossStream/node-sqlite3
that referenced
this pull request
Jul 1, 2020
Just shared as demo May be changed Change-Id: I79000463955d16eec8809c870f7d02c60da53432 Bug: TryGhost#418 Forwarded: TryGhost#1112 TryGhost#1028 Origin: https://github.com/tizenteam/node-sqlite3 Signed-off-by: Philippe Coval <p.coval@samsung.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: I79000463955d16eec8809c870f7d02c60da53432
Bug: #418
Forwarded: #1028
Origin: https://github.com/tizenteam/node-sqlite3
Signed-off-by: Philippe Coval p.coval@samsung.com