Fix SimulateIncomingAchPaymentDTO missing status arg - #86
Merged
Conversation
from_json_api omitted status when constructing BasePayment, shifting positional args and raising TypeError on a successful sandbox response. Mirror SimulateAchPaymentDTO.from_json_api and pass status through __init__. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimulateIncomingAchPaymentDTO.from_json_apiomittedstatuswhen constructingBasePayment, so remaining positional args shifted (direction→status,description→direction, …) and a successful Unit sandbox simulate-incoming-ACH response raisedTypeError.SimulateAchPaymentDTO.from_json_api, which already passesattributes.get("status").__init__to passstatusintoBasePayment.__init__(it previously skipped it and setattributes["status"]after the fact).Test plan
SimulateIncomingAchPaymentDTO.from_json_apiwith a sandbox-shaped payload (includingstatus) constructs withoutTypeErrorsimulate_incoming_ach_paymentworks against Unit sandbox without an api-repo monkeypatch offrom_json_apiMade with Cursor