Repository navigation
Conversation
gHashTag
force-pushed
the
fix/ext-zero-js-189-v2
branch
from
April 21, 2026 05:23
5befbaf to
5e5b45e
Compare
Remove unused imports, fix needless returns/mut, use .first() instead of .get(0), add Default impl for GhClient. Refs #189
49 of 65 tasks
#189) - Add crates/xtask with build-ext and ci-check commands - build-ext: wasm-pack + generate shim files + clean rogue JS - ci-check: L9 (no JS outside dist/), CSP (no inline scripts), artifacts - Add CSP inline-script check to CI workflow - Add xtask ci-check step to CI - No .sh files used (L7 compliant — Rust build pipeline)
Remove unused imports, fix needless returns/mut, use .first() instead of .get(0), add Default impl for GhClient. Refs #189
…ix trinity_sweep clippy — refs #189 CI
Collaborator
Author
|
Superseded by #197 (merged) |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension/bg-sw.js(L9: no JS outside dist/)extension/trios_ext_bg.wasm(should be in dist/wasm/ only)crates/trios-ext/dist/bg-sw.js(auto-generated WASM loader)Verification
cargo clippy --all-targets --all-features -- -D warnings= 0cargo test --workspace= 425+ tests, 0 failuresfind extension -name "*.js" -not -path "*/dist/*"= emptyCloses #189