Skip to content

WARNING_CEILING = 4 это показание, а не требование: четыре устаревших вызова в одном файле #1272

Closed

Description

@gHashTag

Найдено вторым вопросом к порогам: не «умеет ли падать», а «почему он зелен именно на этом числе».

WARNING_CEILING := 4 равен ровно числу предупреждений '+' was deprecated in macOS 26.0 в BR-OUTPUT/RichTextRenderer.swift, строки 73, 75, 77, 79. То есть потолок выставлен по замеру, а требование — ноль.

Это та же форма, что месяцами стояла в XCTEST_ERROR_CEILING = 2, где двойка была числом ошибок, которые давал сломанный список исходников. Там она обнаружилась только когда список починили: настоящее число оказалось 23, а после починки тестов — 0, и потолок стал требованием.

Почему не опущено сегодня

Правка не однострочная. Четыре вызова склеивают Text с разным начертанием — жирный, курсив, моноширинный:

segments.reduce(Text("")) { acc, seg in
    switch seg {
    case .plain(let s):  return acc + Text(s)
    case .bold(let s):   return acc + Text(s).fontWeight(.bold)
    case .italic(let s): return acc + Text(s).italic()
    case .code(let s):   return acc + Text(s).font(.system(.body, design: .monospaced))
    }
}

Современная замена — переписать styledText на AttributedString, а не подставить другую операцию. Это меняет отрисовку, а отрисовка не проверяется по журналу сборки: правило репозитория запрещает называть правку интерфейса невидимой, если на неё нельзя посмотреть.

Что нужно

  • Переписать styledText на AttributedString, сохранив три начертания.
  • Посмотреть глазами на богатый текст в чате: жирное, курсив, код — до и после.
  • Опустить WARNING_CEILING до нуля, и тогда число станет требованием.

До тех пор комментарий у потолка говорит прямо, что четвёрка — показание с названным долгом.


User Scenarios & Testing

User Story 1 - The ceiling's comment stops contradicting the ceiling (P1)

Why this priority: the constant and the paragraph above it now say opposite
things. WARNING_CEILING := 0 sits directly beneath a block that opens "WHY
FOUR, ASKED HONESTLY. This number is a READING, not a requirement" and states
"It is not lowered to zero today". The debt that paragraph names was paid: the
AttributedString rewrite of styledText landed in commit ee8f61ef3, no
Text + concatenation survives anywhere in the tree, and the ceiling was
lowered to 0. A record that argues against its own value is the same defect this
issue was opened about, only pointing the other way.

Independent Test: grep -n "It is not lowered to zero today" Makefile
returns nothing, and grep -n "WARNING_CEILING :=" Makefile still returns
WARNING_CEILING := 0.

Acceptance Scenarios:

  1. Given the Makefile at WARNING_CEILING,
    When a reader looks at the comment above it,
    Then it states the requirement of zero and records the four Text
    concatenations as history, and no sentence in it is written in the present
    tense about an unpaid debt.
  2. Given the citation BR-OUTPUT/RichTextRenderer.swift lines 73/75/77/79,
    When those lines are opened in the file as it stands today,
    Then they are var result = AttributedString(),
    result += styledText(for: segment) and return result - so the citation
    points at innocent lines and MUST NOT survive as a present-tense claim.
  3. Given the paragraph that records the XCTEST_ERROR_CEILING lesson
    ("asking 'why is it green at this number' is what found it"),
    When the stale sentences around it are removed,
    Then that lesson is still present in the file, because it is the reason
    this issue exists and it did not become false.

User Story 2 - The skill that quotes the reading is corrected too (P2)

Why this priority: .claude/skills/e2e-testing/SKILL.md carries the same
claim in the present tense - "It is 4, which is exactly the four deprecated
Text concatenations in one file" and "So the number stays". An agent that
reads that skill before touching the gate is told the tree still owes four
warnings. One false sentence in two places is one defect, not two.

Independent Test:
grep -c "It is 4, which is exactly the four deprecated" .claude/skills/e2e-testing/SKILL.md
returns 0.

Acceptance Scenarios:

  1. Given the ceiling section of the e2e-testing skill,
    When it is read after the change,
    Then it records the sequence - 4 was a reading, the AttributedString
    rewrite removed the four concatenations, the ceiling is now 0 and derived
    from the requirement - rather than saying the number stays at 4.

Requirements

  • FR-001: The stale justification block in Makefile MUST be removed: the
    sentences "WHY FOUR, ASKED HONESTLY. This number is a READING, not a
    requirement", the citation "lines 73/75/77/79", and "It is not lowered to zero
    today because the fix is not a one-liner" MUST NOT appear in the file.
  • FR-002: The comment that remains above WARNING_CEILING MUST state that
    zero is a requirement and MUST record, in the past tense, that the value was 4
    for as long as BR-OUTPUT/RichTextRenderer.swift concatenated Text values
    with the deprecated +, and that the AttributedString rewrite removed them.
  • FR-003: The XCTEST_ERROR_CEILING lesson MUST survive: the string
    why is it green at this number MUST still be present in Makefile.
  • FR-004: WARNING_CEILING := 0 MUST remain unchanged, and the warnings
    recipe MUST NOT change. Every added and removed line in the Makefile diff
    MUST begin with #.
  • FR-005: The ceiling passage in .claude/skills/e2e-testing/SKILL.md MUST
    be rewritten so that no sentence asserts in the present tense that
    WARNING_CEILING is 4 or that "the number stays"; it MUST say the ceiling is
    now 0 and why.
  • FR-006: BR-OUTPUT/RichTextRenderer.swift MUST NOT be edited. The rewrite
    this issue asked for is already in the tree and the file is outside this
    boundary; a bee that changes it is redoing landed work and touching a file it
    does not own.
  • FR-007: No new make target, gate or test MUST be added. This task
    changes recorded text only.
  • FR-008: Everything written MUST be ASCII, matching the surrounding
    Makefile text.

Success Criteria

  • grep -c "WHY FOUR, ASKED HONESTLY" Makefile prints 0.
  • grep -c "It is not lowered to zero today" Makefile prints 0.
  • grep -c "73/75/77/79" Makefile prints 0.
  • grep -c "why is it green at this number" Makefile prints 1.
  • grep -c "WARNING_CEILING := 0" Makefile prints 1.
  • grep -c "It is 4, which is exactly the four deprecated" .claude/skills/e2e-testing/SKILL.md
    prints 0.
  • git diff -U0 -- Makefile | grep -E "^[+-]" | grep -vE "^(\+\+\+|---)" | grep -cvE "^[+-]#"
    prints 0: the Makefile diff is comment lines only.
  • git status --porcelain lists exactly 2 modified files, and
    BR-OUTPUT/RichTextRenderer.swift is not one of them.
  • LC_ALL=C grep -n "[^ -~]" Makefile prints nothing for any line the diff added.

Boundary

./Makefile
.claude/skills/e2e-testing/SKILL.md

Activity

  1. gHashTag commented on Sep 1, 2026

    @gHashTag
    CollaboratorAuthor

    Queue hygiene: Queen reports this task as accepted and the work as already landed. Closing the tracking issue removes a completed candidate from every future scheduling round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions