Repository navigation
W975: the format's signed MAC fails on silicon (clauses 0011, ok=0) while passing 2/2 in simulation - #683
Merged
Conversation
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format's signed MAC fails on silicon while passing every test it has
Both operators, same bench, same session, same toolchain, with the control satisfied:
okgft_sadd1111gft_signed_mac0011The control is not decoration. A foreign bitstream forced
Done = 0before ours brought it to 1, soDone = 1afterwards means the die genuinely reprogrammed.beat = 1in both reads — the MAC is loaded, clocking, and answering incorrectly.Timing is not the obvious explanation: the MAC closed at 9.14 MHz against a 2.21 MHz target — 4.1× margin. A design failing two clauses at a quarter of its achievable frequency is not a straightforward setup violation.
The sharper finding is about the tests, not the silicon
The MAC's spec ships two simulation tests and both pass. Its on-die check evaluates four clauses, and two of them are false.
The die check is stronger than the suite the spec carries. The failing clauses are simply not covered in simulation.
So this is not "the simulator lies" — it is a coverage gap made visible by hardware, discovered at the most expensive possible point: after synthesis, place-and-route, bitstream generation and a physical load.
gft_sadd, by contrast, carries three tests and satisfies all four clauses; its suite and its die check agree because its behaviour is correct in both.Consequence for L4 (TESTABILITY)
A spec satisfies L4 by containing
test/invariant/bench.gft_signed_macdoes — and its tests are weaker than a check this same project already runs. Passing one's own tests is not evidence of correctness when a stronger oracle exists in the same repository, and the ladder's central arithmetic operator is the case that demonstrates it.The remedy costs nothing: derive the simulation tests from the on-die clauses, so the cheap oracle asks every question the expensive one does.
What must not be concluded
gft_saddbeing green vindicates the format. It establishes that the path and the reader are sound — which is exactly what makes the MAC's red meaningful.281 derived checks, all passing. Related: #680, #681, #682.
🤖 Generated with Claude Code