Skip to content

Port gHashTag/trinity:fpga/openxc7-synth/ternary_matvec_243x729_top.v (Verilog, 1 module) to specs/port/trinity/fpga/ope - #9404

Merged
gHashTag merged 2 commits into
masterfrom
queen-9369
Oct 13, 2026
Merged

gHashTag merged 2 commits into
masterfrom
queen-9369

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Closes #9369

Written by a bee on queen-9369 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 602 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 13, 2026 12:12
Translates fpga/openxc7-synth/ternary_matvec_243x729_top.v (trinity
e71d166ad6ef) into a .t27 spec that t27c lowers back to equivalent
Verilog: the 4-state self-test FSM with 20-cycle power-on reset hold,
mv_start pulse timing, streaming j_mod3 result verification against
the repeating {-81, 162, -81} expected pattern, active-low LED
blink/verdict drive, debug_state decoding, bit-serial UART TX, and the
20-byte result reporter frame. The BRAM core, UART RX and clock
wiring are external dependencies and remain undefined stubs; the
decision logic they surround is fully specified and tested (12 tests,
17/17 functions covered, 0 vacuous passes).

Closes #9369
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #9369

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-13 12:33:18 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 49
PRs with All Checks Green 1
READY 0
FAILING 49
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 49 + 0 + 0 = 49, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e769ef021713 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@tri-claw tri-claw Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer bee verdict for head 48f0107f6be32a2b83b0628cc697ad8cc69e4878 (tools/bees/reviewer.py, zai glm-4.7-flash, glm-4.5-flash, 12 turns, 260 s; then glm-4.7-flash, 5 turns, 530 s).

BEE-VERDICT: APPROVE
summary: Successfully ported ternary_matvec_243x729_top.v to t27 format with all acceptance criteria met
criterion: Port gHashTag/trinity:fpga/openxc7-synth/ternary_matvec_243x729_top.v to specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 -- met -- PASSED all 6 acceptance criteria per brief
discounted-check: cli-tri -- build warnings on unused functions in existing CLI code, unrelated to the port (brief line 698-748)
discounted-check: duplicate-bodies -- already failing on master with "No new duplicate body" (brief line 648-649)
discounted-check: t27b-native-ratchet -- already failing on master (brief line 752)

Evidence

Based on my review of the brief and the diff, here's my analysis:

Evidence

Acceptance Criteria Verification

The brief shows that all acceptance criteria were met:

  1. ✅ test -f specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 && echo present printed present
  2. ✅ grep -cE '^\s*(pub )?module ternary_matvec_243x729_top\b' specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 printed 1
  3. ✅ t27c gen-verilog specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 | grep -cE '^module ternary_matvec_243x729_top ?\(' printed 1
  4. ✅ t27c spec-status specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 printed IMPLEMENTED (not NOPARSE)
  5. ✅ grep -cE '^[[:space:]]*test[[:space:]]+("|[A-Za-z_])' specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 printed 12 (at least 1)
  6. ✅ t27c test-report specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 2>&1 | grep -c BLOCKED printed 0

Red Checks Analysis

  1. duplicate-bodies: This failure is on master (69b0efb: failure) and the runner confirms "No new duplicate body, and no known group grew". This check was already red on master and the PR didn't introduce new duplicates.

  2. cli-tri: This failure is on build warnings from cargo build -p tri --all-targets in the cli/tri package. The log shows this is unrelated to the port - it's about unused functions in existing CLI code (check_staged, PidPath, plan, label). The runner states "on master: not run on the last 6 commits of master" suggesting this may be a pre-existing issue.

  3. t27b-native-ratchet: This check was already red on master (69b0efb: failure) as stated in the brief. The runner's master conclusion shows this check was already failing.

Boundary Compliance

The diff shows exactly:

  • Added: docs/now/2026-10-13-published-port-ghashtag-trinity-fpga-openxc7-synth-ternary-matvec-243x.md (documentation)
  • Added: specs/port/trinity/fpga/openxc7-synth/ternary_matvec_243x729_top.t27 (the port)

No files were edited outside the boundary. The file contains 12 tests covering all major functionality including:

  • Expected value pattern verification
  • POR behavior
  • Self-test FSM states
  • LED behavior
  • UART TX functionality
  • Report frame layout

Port Quality

The port properly converts the Verilog module to t27 format:

  • All constants are preserved exactly as in the original
  • State machines are modeled with structs and functions
  • The hardware surface maintains the same register interface
  • Tests verify all behavioral aspects match the original

Second, independent review (glm-4.7-flash): APPROVE -- Ports the ternary_matvec_243x729_top Verilog module to .t27 with all required components, passes all 6 acceptance criteria, and does not introduce any new defects.

@tri-claw tri-claw Bot added the bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525) label Oct 13, 2026
@gHashTag
gHashTag enabled auto-merge (squash) October 13, 2026 12:57
@gHashTag
gHashTag merged commit 223fd5c into master Oct 13, 2026
29 of 32 checks passed
@gHashTag
gHashTag deleted the queen-9369 branch October 26, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bee-reviewed A reviewer bee reviewed and verified this PR at its current head; the only merge signal (#5525)

Projects

None yet

2 participants