Skip to content

Port gHashTag/BrowserOS:trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.ts (TypeScript, 5 functio - #7169

Merged
gHashTag merged 6 commits into
masterfrom
queen-5468
Oct 22, 2026
Merged

gHashTag merged 6 commits into
masterfrom
queen-5468

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Closes #5468

Written by a bee on queen-5468 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 52 insertions(+)

🤖 Generated with Claude Code

Trinity Bee and others added 4 commits October 1, 2026 20:57
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #5468
Turn: ee9751c6-3494-40cc-8fbb-791261f110ac
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 0 path(s) outside the declared boundary
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #5468
Turn: fea7eb50-7e4a-40d5-9632-009201dc76b1
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 1 path(s) outside the declared boundary
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #5468

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 23:37:40 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 42
PRs with All Checks Green 8
READY 1
FAILING 42
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 42 + 0 + 0 = 43, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=b23641f01baa != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026
…5468, #7573)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-07 18:58:47 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 47
PRs with All Checks Green 3
READY 1
FAILING 47
PENDING 0
NO CHECKS YET 0

These columns do not partition: 1 + 47 + 0 + 0 = 48, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=66b6e1375e37 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-22 17:42:32 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 33
PRs with All Checks Green 17
READY 0
FAILING 33
PENDING 0
NO CHECKS YET 4

These columns do not partition: 0 + 33 + 0 + 4 = 37, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=5aec047d42ec != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@tri-claw

tri-claw Bot commented Oct 22, 2026

Copy link
Copy Markdown

Summary by t27-bees

Checked by the t27 compiler

t27c parse, parse-complete and typecheck on each changed .t27 file at 9224485. Nothing was generated, built or run. A pass means the file is well formed, not that it is right.

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27: parses and typechecks.

Read by the model

This PR adds a t27 port of a BrowserOS mock language model client with five stub functions and their tests. All functions return hardcoded values and ignore their input parameters.

Worth a look

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27: All five functions (createMockResult, isMockBrowserOSLLMEnabled, shouldUseMockBrowserOSLLM, resolveMockBrowserOSConfig, createMockBrowserOSLanguageModel) accept parameters but never use them. If the original TypeScript implementations relied on these parameters for conditional logic, the port loses that behavior.

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27:14-19: shouldUseMockBrowserOSLLM takes a provider: str but unconditionally returns true. If the original checked for specific providers (e.g., only "browseros"), this would incorrectly enable mock for all providers.

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27:21-28: resolveMockBrowserOSConfig takes provider, model, and browserosId (all optional) but returns hardcoded 1. If the original returned different config objects based on these inputs, callers may receive wrong configuration.

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27: Return types are i32 for functions that may have returned objects/records in TypeScript (e.g., createMockResult, resolveMockBrowserOSConfig, createMockBrowserOSLanguageModel). Without the original TypeScript signatures, it's unclear if i32 is a placeholder or the intended port type.

  • specs/port/browseros/trios/agent-server/apps/server/src/lib/clients/llm/mock-language-model.t27: Missing newline at end of file (the diff shows \ No newline at end of file). Some tooling may warn or fail on this.


Read: 2 files, +63 -0, the whole diff. Head 9224485. Model: openai-compatible/nvidia/nemotron-3-ultra-550b-a55b. Commands: @t27-bees review | summary | help | pause | resume. Free for every repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants