Repository navigation
fix(rust): a bare *T does not parse; supply the qualifier C already supplies (+10) - #3217
Merged
Merged
Conversation
…upplies (+10) `param_type_to_c` has carried the C half of this since it found the same text passing through verbatim in 52 generated files. The Rust half was never written, and Rust is stricter -- a raw pointer with no `const` or `mut` does not parse at all, so everything behind it in the file was invisible to any first-error histogram. Largest mechanical class left in the column: 39 of 339 first errors. Three spellings arrive at this arm. Prefixing `*mut` unconditionally produced `*mut const BezierCurve` and regressed specs/tri/math/bezier.t27: +8 but -1. `*const T` and `*mut T` are already Rust and pass through untouched; only the bare `*T` needs a qualifier, and bare means mutable in the source language. Measured by name over all 650 corpus specs: rustc accepts 242 -> 252, +10, zero regressions. The one regression of the naive version was worth more than its eight gains -- it is what named the second spelling. A prediction written before measuring said 0-2, reasoning that a raw pointer would give E0609 in the body instead. Wrong by fivefold: these specs use pointers in the signatures of stub functions whose bodies are `unimplemented!()`. Seal and 69 drifted seals move in the same commit; only gen_hash_rust and sealed_at change. Closes #3216 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
September 5, 2026 00:41
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-09-05 00:53:06 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
param_type_to_chas carried the C half of this since it found the same text passingthrough verbatim in 52 generated files. The Rust half was never written, and Rust
is stricter: a raw pointer with no
constormutdoes not parse at all, soeverything behind it in the file was invisible to any first-error histogram.
It was the largest mechanical class left in the Rust column: 39 of 339 first
errors, second only to
mismatched types(74).Three spellings arrive here, and a naive fix regressed a spec
Prefixing
*mutunconditionally gave*mut const BezierCurveonspecs/tri/math/bezier.t27, which had been accepted before. Measured: +8 but −1.*const Tand*mut Tare already Rust and must pass through untouched; only thebare
*Tneeds a qualifier, and bare means mutable in the source language.With all three spellings handled: +10, 0 regressions.
Measured, 650 corpus specs, by name
A prediction that was refuted, recorded because it was wrong
Before measuring I wrote that this would unblock 0–2 specs, reasoning that
cell.valueon a raw pointer gives E0609 rather than compiling, so the fix would onlymove the error deeper. It unblocked 10. The reason is visible in the output: these
specs use pointers in the signatures of stub functions whose bodies are
unimplemented!(), so nothing ever dereferences them and repairing the signature issufficient.
Third instance this pass of the same shape: a rule that exists in one emitter and
never travelled to its sibling — after the serde gate (#3208) and the bracket element
type (#3213).
Closes #3216