Repository navigation
tri: say the binary is unbuilt instead of repeating t27c's error (Refs #2559) - #2563
Merged
Merged
Conversation
Routing the 17 subcommands (#2561) does nothing on a fresh clone: with target/ empty there is no `tri` binary to route to, so the now-sync gate's own remediation still answers `unrecognized subcommand 'now'` -- the exact error the routing fix was meant to end. The front door now says the binary exists, is not built, and how to build it, then falls through so t27c's error still prints. It does not claim WHICH commands the unbuilt binary has, because nothing at that point can know; the hint is phrased "if '<cmd>' is one". Verified by moving BOTH binaries aside. My first attempt hid only target/debug/tri and the command kept working, because target/release/tri answered -- hiding one of two proves nothing. The eight names both binaries carry are still byte-identical, cmp'd again after this change. Refs #2559
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2561, which routed 17 subcommands to the Rust
tribinary. That fix does nothing on a fresh clone: withtarget/empty there is no binary to route to, sonow-sync-gate's own remediation still answersunrecognized subcommand 'now'— the exact error the routing was meant to end. The case the fix missed is the first-time one.The front door now says the binary exists, is not built, and how to build it, then falls through so t27c's error still prints. It deliberately does not claim which commands the unbuilt binary has — nothing at that point can know — so the hint reads "if '' is one". Checked against a nonsense command: it hedges rather than asserting.
On the verification. My first emulation of a fresh clone was wrong: I hid
target/debug/triand the command kept working, becausetarget/release/trianswered. Hiding one of two binaries proves nothing. Both moved aside, the failure reproduces; both restored, routing works and the 8 shared names are byte-identical undercmpagain.Refs #2559