Repository navigation
fix(tri): marker before dirty-guard; and a control that kills nothing (#2492) - #2535
Merged
Merged
Conversation
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interrupt marker caught a real one
A run from the previous iteration had been orphaned and left
gft_backprop_microcode.pymutated. The marker named the gate, printed the recovery commands, and I ran exactly what it printed —git checkout -- tools/on the directory, which is the instruction #2530 says I should have followed the first time.And it spoke second, which is the wrong order. The dirty-tree guard fires first, and after an interrupt the tree is dirty — so the informative message existed and was never the one shown. The marker is now checked first. Found by hitting a real interrupt and reading the wrong error.
An orphaned run was still alive
Thirteen minutes in, mutating files, from an iteration I had already reported as finished. Third time mutants got loose, and every time the cause was mine: starting a long background job and losing track of it.
The guard did refuse the concurrent run I started on top of it — an unplanned safety property, since two mutation loops would each restore the other's mutations and produce numbers that describe nothing.
Seventeen of twenty-one rows, and one is stark
Its control kills nothing. Not one of seventeen mutants, across four operators.
I gave that gate a control three iterations ago (#2520) — three planted cases, all passing, covering the skip pair and the codegen-failure branch — and none of the sites the operators can reach are among them.
Same class as
verify_exhaustive.pybefore #2515: a control that exists, passes, and is not connected to the verdicts anyone would break. Worse here, because I wrote this one knowing that class, and the number that exposes it could not be produced until the run learned to be interruptible (#2533).The table is 17 of 21 and says so
The remaining four are still measuring; the cache means the next run finishes them rather than starting over. A partial table reported as partial is a measurement; the same table reported as complete is the thing this campaign is about.
Refs #2492