Repository navigation
fix(gates): the last gate gets a control — 21 gates, 0 uncovered (#2492) - #2528
Merged
Merged
Conversation
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
21 gates, 0 with no control in any form. The count that opened this campaign at 4 of 12 is at zero, across a set two-thirds larger and selected by property rather than by name.
The last one
gft_backprop_microcode.pycarried sixteenasserts — XOR trains to 4/4, held-out clears 90%, the emitted Verilog carries the ports it claims — and nothing showed that any of them could go red. Sixteen assertions and no evidence they assert anything.Three planted cases now:
assert acc == 4firesEach demands the assertion's own message, because an
assertdelivers its verdict through a traceback: exit 1 means both "XOR did not train" and "somebody typed a name wrong".Building it corrected #2524's null result
That PR measured "do any CI-invoked tools fail ONLY through assert?" — answer zero, no gate is invisible to the selector — and I reported it as if it settled the matter. It does not.
The mutation operators score this gate 0/0 silent, 0/0 loud, 0/0 invert. Its verdicts are asserts, which no operator recognises, so every verdict in this gate is invisible to three of the four questions. The selector sees the file (via a ternary returning a class label — #2524's accident); the operators see none of its sixteen assertions.
Two different questions — "is this file classified as a gate?" and "can its verdicts be broken and noticed?" — and I answered the easier one, found nothing, and moved on.
The documented trap, reproduced
The port-rename plant spelled its needle literally, so the first occurrence of that string in the file became the control's own source line, and
str.replace(.., 1)edited the harness instead of the target. The case then reported the gate as blind when nothing had been planted at all.check_duplicate_agreement.pycarries a comment warning about exactly this, written after it happened there. I had read that comment. The fix is to assemble the needle —"input [31:0] x" + "0i"— so it exists as no literal anywhere.Named and left
The boundary column reads 5/31. Those sites are arithmetic internals — encodings, magnitude comparisons — where moving a comparison is a numerical change rather than a verdict change. A different kind of surface, larger than anything else outstanding, and not this campaign's question.
Refs #2492