Skip to content

fix(gates): a deleted tracked spec is broken, not skipped; extract _prereq (#2492) - #2523

Merged
gHashTag merged 1 commit into
masterfrom
fix/prereq-module
Aug 23, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/prereq-module

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

#2520 gave a mechanical test: every skip claims that the thing missing is not the subject of this check. Fourteen calls in the tree; read each as that sentence and two do not survive.

Two skips that were failures

Both are a spec file tracked in git. verify_emit_bitexact skipped when gft_smul.t27 / gft_sadd.t27 were absent; verify_igla_race when ternary_mac.t27 was.

Measured, not argued — renaming the file aside:

gate before after
verify_emit_bitexact.py exit 0, "SKIP … specs not found" exit 1, "FAIL … tracked in this repository and not on disk"
verify_igla_race.py exit 0, "SKIP … not found" exit 1, same shape

A deleted spec is not a bare machine. It is the repository missing the thing the gate exists to verify, and the sentence "the missing spec is not the subject of this check" is simply false. Both now call broken(): fatal with or without --require. --require should not be what saves you from a deleted source file.

The extraction, at the one safe moment

Four hand-copied skip()s had just been made to behave identically (#2518, #2519, #2520) — which is the only time a deduplication is a pure deduplication. tools/_prereq.py now holds both words, with the rule that separates them written where the code is rather than in a comment inside one of four copies, which is exactly how the four came to disagree.

The extraction broke a control on its first run, and the control said so

verify_multitarget's planted tree carried the script and not the module it now imports, so the child died at import with empty stdout — and the case refused to read that as a skip. A plant must carry everything the thing under test needs; adding a shared dependency changes what "everything" means, and the only cheap way to learn that is a control that fails loudly.

Two assertions also moved: messages now name the script from argv rather than a constant, so SKIP verify_multitarget became SKIP verify_multitarget.py. A control asserting exact text is a control that notices a message changing — which is the point, even when the change is mine.

Verified

All five self-checks green. verify_igla_race, verify_multitarget, verify_trainer_c still exit 0 on a healthy tree. This PR touches four files in the twenty-minute emit-bitexact job, so it waits for that job rather than for the checks beside it.

Refs #2492

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-23 10:09:15 UTC

Summary

Status Count
Total Open PRs 7
PRs with Failing Checks 3
PRs with All Checks Green 4
READY 3
FAILING 3
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 05cb2d2 into master Aug 23, 2026
24 of 26 checks passed
@gHashTag
gHashTag deleted the fix/prereq-module branch August 23, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant