Skip to content

feat(tri): select gates by property; the workflow heuristic lied on first use (#2492) - #2513

Merged
gHashTag merged 2 commits into
masterfrom
feat/gates-by-property
Aug 23, 2026
Merged

gHashTag merged 2 commits into
masterfrom
feat/gates-by-property

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

#2512 disclosed that the file filter was narrower than the control search. Measuring the hidden files turned that disclosure into three findings, two of them about this command.

A correction first: the disclosure line was itself off by two

It printed 13 of 28 where 15 files match by name — rows.len() is the count after the two control files are excluded. The line added for honesty understated the match by exactly the number of controls, and I repeated its number in a report. It now reads 17 gate(s) from 28 *.py … control files excluded.

Naming was never the property

It failed as check- vs check_ (#2509), and again as verify_* / run_*. The property that matters is measurable: a workflow invokes it and it can exit non-zero. Anything that can turn a pipeline red is a gate whether or not its name says so.

Selection is now by-name or by-property. The count moved 13 → 17, and the three that surfaced — fuzz_trainer.py, run_conformance_vvp.py, verify_multitarget.py — run in CI, carry verdicts, and have no control in any form. Invisible for the whole campaign to a command whose output looks exhaustive.

And the workflow heuristic lied on its first real use

#2512 added it with the explicit warning that upgrading "no control" to "controlled" is the one error direction that hurts here. It then did exactly that, for all three, on the strength of the word must sitting in a prose comment 760 lines from the call.

Tightened two ways:

  • only vocabulary somebody chooses on purpose — fixture, expect_, planted. must and broken are dropped: both are ordinary English in a workflow comment.
  • within 30 lines of an invocation

Both directions are asserted: a fixture path beside the call is found; prose 60 lines away is not.

The cross-check worth keeping

Pointed at the second repository, the tightened version independently reproduced the by-hand measurement from #2511 — the same three gates controlled (check_build_paths, conformance_check, signal_health), by the same evidence. A heuristic agreeing with a careful manual pass on a corpus it was not tuned against is the closest thing to a control this kind of search can have.

15 unit tests green.

Refs #2492

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-23 08:08:52 UTC

Summary

Status Count
Total Open PRs 6
PRs with Failing Checks 2
PRs with All Checks Green 4
READY 3
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@gHashTag
gHashTag merged commit f35adc0 into master Aug 23, 2026
22 of 24 checks passed
@gHashTag
gHashTag deleted the feat/gates-by-property branch August 23, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant