Repository navigation
fix(tri): the loud operator excluded ternaries on a reason I invented (#2492) - #2496
Merged
Merged
Conversation
…#2492) The comment said: "forcing a ternary's whole line to 1 is the Silent operator's job seen backwards". It is not. Silent forces the line to 0 -- the gate never fails. Loud forces it to 1 -- the gate always fails. Two different mutants of one line. Excluding one printed `no success path to break` for a gate whose every verdict is a ternary. That row read as a clean score and was an absence of measurement. Allowing ternaries found two more survivors immediately, and both were FALSE: first_line() returning a string with an index in it, and _is_exact_zero() returning `v == 0`. Both predicates scanned for a standalone digit anywhere in the expression, so an index and a comparison read as verdicts. The silent predicate had the same weakness for 1..4: `return v == 1` would have been a site. Strict now: a return is a verdict when the whole expression is a literal, or a ternary whose two arms are literals. Denominators moved downward -- elab_ratchet 10 -> 6, wp18 6 -> 2, catalog_count 4 -> 3, duplicate_agreement 4 -> 3. Those kills were real and were noticing mutations of helper functions. A higher denominator looked like more thorough measurement and was measurement of the wrong thing. Loud is now all-killed everywhere except wp18_conformance_gate, whose success return is a variable and correctly not a site. Refs #2492
Two gates reported "no success path to break" on a reason I wrote: "forcing a ternary's whole line to 1 is the Silent operator seen backwards". It is not -- silent forces 0, loud forces 1, two mutants of one line. The sentence had the shape of a careful distinction, which is why it lasted, and it printed a row that read as a clean score while being an absence of measurement. Plus: a predicate that scans for a digit is not a predicate for a verdict. Allowing ternaries found two survivors and both were false -- an index and a comparison read as verdicts. Strict: a literal, or a ternary of two literals. And: a denominator that grows can mean worse measurement. The counts fell when the predicate tightened; the earlier kills were real and were noticing mutations of helper functions. Refs #2492
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday two gates reported
no success path to breakand I documented that as an honest limit, with a reason:It is not. Silent forces the line to
0— the gate never fails. Loud forces it to1— the gate always fails. Two different mutants of one line.Excluding one printed a clean-looking row for a gate whose every verdict is a ternary. That row was an absence of measurement.
Allowing ternaries found two more survivors, and both were false
Helper functions returning values. Both predicates scanned for a standalone digit anywhere in the expression, so an index and a comparison read as verdicts. The silent predicate had the same weakness for
1..4:return v == 1would have been a site.Strict now: a return is a verdict when the whole expression is a literal, or a ternary whose two arms are literals.
The denominators moved downward
check_elab_ratchetwp18_conformance_gatecheck_catalog_countcheck_duplicate_agreementThose earlier kills were real — the controls did notice. They were noticing mutations of helper functions. A higher denominator looked like more thorough measurement and was measurement of the wrong thing.
Where both operators stand
wp18_conformance_gate, whose success return isreturn code— a variable, correctly not a site, and the row now saysno success path to breakfor a reason that is true.UNCOVEREDwith its reason.Three of my justifications have been wrong in this campaign
Two produced missing coverage. This one produced a row that read as a score — which is worse, because the first kind gets found by the next person who looks and the second gets quoted.
Refs #2492