Skip to content

test(ci): the ledger-writing path nobody ran, and the mirror of the first finding (#2492) - #2494

Merged
gHashTag merged 2 commits into
masterfrom
test/loud-survivors
Aug 23, 2026
Merged

gHashTag merged 2 commits into
masterfrom
test/loud-survivors

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

--loud found eight sites where nothing required a gate to be silent. Five are closed here; the three that remain are a different class and are named with their reason.

Four were one shape: the success return of --update-baseline

Right after "baseline written: N entries" — in check_json_parses, check_seal_coverage, check_specs_generate, check_withdrawn_live.

Nothing in the tree ran the ledger-writing path at all. A --update-baseline that wrote the ledger and then reported failure was invisible to every control.

Each new case asserts the exit and the effect: exit alone would pass a run that returned 0 without writing, and the marker alone would pass one that wrote and then reported failure — which is the mutation that found this.

check_specs_generate already had an --update-baseline case, but it asserts the refusal to grow the ledger. The success path needed a tree where the ledger shrinks.

The fifth was mine, and the worst

check_gate_preconditions.py — the file that enforces this discipline for six other gates:

OK: 9 precondition(s) across 6 gates fail loudly; 1 known-uncovered
exit 1
control: exit 0 -- nothing noticed

Its control now runs the whole program on a tree where every gate is healthy and asserts exit 0 and the count, because an exit 0 from a table that silently emptied would satisfy the code alone.

The three that remain are report modes, not verdicts

site guard the file's own words
check_specs_parse.py:302 --all "a report, not a gate"
check_elab_ratchet.py:440 --allow-missing-tools "reporting nothing, deliberately"
check_specs_generate.py:375 a counts-table branch —

Covering them means asserting that report modes exit 0. Worth doing, not the same finding, so left with its reason rather than folded into the count.

Method note

The four --update-baseline fixes came from one shape read once, not four investigations. --loud grouped them by putting the same line in four reports; the reading turned "eight survivors" into "one class and three exceptions".

Refs #2492

…irst finding (#2492)

--loud found eight sites where nothing required a gate to be silent.
Five are closed here.

FOUR were the success return of --update-baseline, right after "baseline
written: N entries": check_json_parses, check_seal_coverage,
check_specs_generate, check_withdrawn_live. Nothing in the tree ran the
ledger-writing path at all -- a run that wrote the ledger and then
reported failure was invisible to every control.

Each new case asserts the exit AND the effect. Exit alone would pass a
run that returned 0 without writing; the marker alone would pass one that
wrote and then reported failure, which is the mutation that found this.
check_specs_generate already had an --update-baseline case, but it
asserts the REFUSAL to grow the ledger; the success path needed a tree
where the ledger shrinks.

The FIFTH was check_gate_preconditions.py -- the file that enforces this
discipline for six other gates -- printing "OK: 9 precondition(s) across
6 gates fail loudly" and exiting 1 with nothing noticing. Its control now
runs the whole program on an all-healthy tree and asserts exit 0 and the
count, because an exit 0 from a table that silently emptied would satisfy
the code alone.

Three remain and are a different class: report modes behind a flag CI
never passes (--all, --allow-missing-tools, a counts-table branch). Named
with their reason rather than folded into the count.

Refs #2492
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-23 03:14:06 UTC

Summary

Status Count
Total Open PRs 6
PRs with Failing Checks 2
PRs with All Checks Green 4
READY 3
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

Four gates shared an unguarded site: the success return of
--update-baseline. Exit alone passes a run that returned 0 without
writing; the marker alone passes one that wrote and then reported
failure, which is the mutation that found the gap.

One gate already had an --update-baseline case asserting the REFUSAL to
grow the ledger -- the opposite branch. Having "a case for the command"
is not having covered it.

Plus: distinguish report modes from verdicts before counting them. Three
survivors sit behind flags CI never passes and each file says so in its
own words. Eight survivors was accurate; "one class of four, one mirror,
three report modes" is what a reader can act on.

And: the tool groups, the reading classifies. --loud made the shape
visible by putting the same line in four reports; it could not tell that
those four were one fix.

Refs #2492
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-23 03:14:33 UTC

Summary

Status Count
Total Open PRs 6
PRs with Failing Checks 2
PRs with All Checks Green 4
READY 3
FAILING 2
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit c2c0e2e into master Aug 23, 2026
27 of 29 checks passed
@gHashTag
gHashTag deleted the test/loud-survivors branch August 23, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant