Repository navigation
fix(fpga-build): the module set is the directory, not a literal - #2452
Merged
Merged
Conversation
fpga-build iterated a hardcoded 36-name array in main.rs rather than specs/fpga/, and the array had drifted in BOTH directions. Five names have no spec -- sv_emit, firrtl, cdc, lint, coverage -- and printed "SKIP (spec not found)" while the command exited 0. Four specs sat in specs/fpga/ and were never generated at all: bpsk (the merged BPSK modem core), power_analysis, ternary_link and vcd_conformance_compare. Generating those four with this same t27c and the elaboration ratchet's own iverilog invocation: 14 errors that nothing counted and nothing bounded. vcd_conformance_compare 13, power_analysis 1, the other two clean. bpsk in particular is a merged, working modem core that no gate in this repository was looking at. Reading the directory makes "the fpga module set" mean what it says. A spec added tomorrow is covered without anyone remembering the list, SKIP disappears because there is nothing to skip, and an empty directory fails loudly instead of reporting success over zero modules. The elaboration ratchet did its job against me: it refused the change with four NEW rows and exit 1 until the increase was recorded deliberately. Baseline 162 errors over 32 modules -> 176 over 36, with the reason written NEXT TO THE NUMBER, because a later reader sees +14 and needs to know it is coverage arriving rather than a regression. The earlier hand-written note survived the update, which is the preservation added in #2441 doing what it was for. Everything else held: yosys 36/36, conformance still executes 18 mac and 3 spi cases, vector-data and withdrawn-live green. The 13 red cargo tests are unchanged and pre-existing (#2292). Refs #2325.
gHashTag
enabled auto-merge (squash)
August 22, 2026 18:57
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 18:58:05 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2325.
fpga-builditerated a hardcoded 36-name array inmain.rsrather thanspecs/fpga/, and it had drifted both ways:sv_emit,firrtl,cdc,lint,coverage— printingSKIP (spec not found)while the command exited 0.bpsk(the merged BPSK modem core),power_analysis,ternary_link,vcd_conformance_compare.Generating those four with this same
t27cand the ratchet's own iverilog invocation: 14 errors nothing counted and nothing bounded (vcd_conformance_compare 13, power_analysis 1, other two clean).bpskin particular is a merged, working modem core that no gate in this repository was looking at.Reading the directory makes the phrase mean what it says: a spec added tomorrow is covered,
SKIPdisappears because there is nothing to skip, and an empty directory fails loudly instead of reporting success over zero modules.The elaboration ratchet did its job against me — it refused the change with four
NEWrows and exit 1 until the increase was recorded deliberately. Baseline 162/32 → 176/36, with the reason written next to the number: a later reader sees +14 and needs to know it is coverage arriving. The earlier hand-written note survived the update, which is the preservation added in #2441 doing what it was for.Everything else held: yosys 36/36, conformance still executes 18 mac + 3 spi, vector and withdrawn gates green. The 13 red cargo tests are unchanged and pre-existing (#2292).
🤖 Generated with Claude Code