Skip to content

fix(fpga-build): the module set is the directory, not a literal - #2452

Merged
gHashTag merged 1 commit into
masterfrom
fix/the-module-set-is-a-directory
Aug 22, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/the-module-set-is-a-directory

Conversation

@gHashTag

Copy link
Copy Markdown
Collaborator

Refs #2325.

fpga-build iterated a hardcoded 36-name array in main.rs rather than specs/fpga/, and it had drifted both ways:

  • 5 names have no spec — sv_emit, firrtl, cdc, lint, coverage — printing SKIP (spec not found) while the command exited 0.
  • 4 specs were never generated at all — bpsk (the merged BPSK modem core), power_analysis, ternary_link, vcd_conformance_compare.

Generating those four with this same t27c and the ratchet's own iverilog invocation: 14 errors nothing counted and nothing bounded (vcd_conformance_compare 13, power_analysis 1, other two clean). bpsk in particular is a merged, working modem core that no gate in this repository was looking at.

Reading the directory makes the phrase mean what it says: a spec added tomorrow is covered, SKIP disappears because there is nothing to skip, and an empty directory fails loudly instead of reporting success over zero modules.

The elaboration ratchet did its job against me — it refused the change with four NEW rows and exit 1 until the increase was recorded deliberately. Baseline 162/32 → 176/36, with the reason written next to the number: a later reader sees +14 and needs to know it is coverage arriving. The earlier hand-written note survived the update, which is the preservation added in #2441 doing what it was for.

Everything else held: yosys 36/36, conformance still executes 18 mac + 3 spi, vector and withdrawn gates green. The 13 red cargo tests are unchanged and pre-existing (#2292).

🤖 Generated with Claude Code

fpga-build iterated a hardcoded 36-name array in main.rs rather than
specs/fpga/, and the array had drifted in BOTH directions.

Five names have no spec -- sv_emit, firrtl, cdc, lint, coverage -- and
printed "SKIP (spec not found)" while the command exited 0. Four specs
sat in specs/fpga/ and were never generated at all: bpsk (the merged
BPSK modem core), power_analysis, ternary_link and
vcd_conformance_compare.

Generating those four with this same t27c and the elaboration ratchet's
own iverilog invocation: 14 errors that nothing counted and nothing
bounded. vcd_conformance_compare 13, power_analysis 1, the other two
clean. bpsk in particular is a merged, working modem core that no gate
in this repository was looking at.

Reading the directory makes "the fpga module set" mean what it says. A
spec added tomorrow is covered without anyone remembering the list, SKIP
disappears because there is nothing to skip, and an empty directory
fails loudly instead of reporting success over zero modules.

The elaboration ratchet did its job against me: it refused the change
with four NEW rows and exit 1 until the increase was recorded
deliberately. Baseline 162 errors over 32 modules -> 176 over 36, with
the reason written NEXT TO THE NUMBER, because a later reader sees +14
and needs to know it is coverage arriving rather than a regression. The
earlier hand-written note survived the update, which is the preservation
added in #2441 doing what it was for.

Everything else held: yosys 36/36, conformance still executes 18 mac and
3 spi cases, vector-data and withdrawn-live green. The 13 red cargo
tests are unchanged and pre-existing (#2292).

Refs #2325.
@gHashTag
gHashTag enabled auto-merge (squash) August 22, 2026 18:57
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-22 18:58:05 UTC

Summary

Status Count
Total Open PRs 5
PRs with Failing Checks 1
PRs with All Checks Green 4
READY 3
FAILING 1
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=e905ba8eeb53 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 14836f7 into master Aug 22, 2026
25 of 28 checks passed
@gHashTag
gHashTag deleted the fix/the-module-set-is-a-directory branch October 26, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant