Repository navigation
fix(tools): the elaboration ratchet counted a phantom error per module - #2435
Merged
Merged
Conversation
iverilog ends a failing file with "N error(s) during elaboration." -- a total, not an error. The counter matched any line containing " error", so every failing module contributed one error that does not exist. Proof rather than inference: after excluding the summary line, every module drops by exactly 1, 25 modules do so, and 186 - 161 = 25 = the number of modules that fail to elaborate. Nothing else moved. The published 573 -> 186 was inflated at both ends by this. Honest on this instrument: 161 real errors across 25 of 32 modules. The docstring also stated a falsehood: "the remainder is two named design decisions". That was measured over unbound-identifier errors only, where it is exact, and written as if it described all of them. The full classification now lives in the docstring -- including 4 malformed statements, which are an emitter defect (a keyword-named parameter escaped at its declaration and emitted bare at its use) and not a decision anyone owns. Refs #2325.
gHashTag
enabled auto-merge (squash)
August 22, 2026 15:45
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-22 15:46:04 UTC
Summary
Seal Status
|
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2325.
My own gate counted iverilog's summary line (
N error(s) during elaboration.) as an error — one phantom per failing module. Proven by the shape of the correction, not argued: every module drops by exactly 1, 25 do so, and 186 − 161 = 25 = the number of modules that fail to elaborate.The docstring also carried a false claim — "the remainder is two named design decisions" — measured over the unbound-identifier errors only and written as though it covered all 161. The full classification is now in the file, and it names a fourth thing that is nobody's decision: 4 malformed statements from a keyword-named parameter escaped at its declaration and emitted bare at its use.
🤖 Generated with Claude Code