Skip to content

fix(parser): tuple return types no longer silently drop the function - #1710

Merged
gHashTag merged 1 commit into
masterfrom
feat/tuple-return-parse
Aug 5, 2026
Merged

gHashTag merged 1 commit into
masterfrom
feat/tuple-return-parse

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

The return-type parser had no ( branch → -> (u32,u32) desynced and the whole function vanished from the AST (1 FnDecl vs 2), breaking all backends. Adds a LParen branch capturing (T, U, …); the function now survives with the correct signature.

Verified: regression test test_tuple_return_type_not_dropped, full suite 1496/0, non-tuple specs unaffected, FROZEN_HASH re-sealed. Part 1 of tuple support (#1702) — body-lowering + let (a,b) destructuring are clearly-scoped follow-ups.

Closes #1709

The return-type parser handled Ident/[...]/void/*T but not '(' (tuple). On
'-> (u32, u32)' it desynced and the whole function vanished from the AST,
breaking every backend. Add a LParen branch that captures (T, U, ...).
Function with tuple return now survives with correct signature.

Part 1 of tuple support (#1702); body-lowering + let (a,b) destructuring are
follow-ups. Regression test test_tuple_return_type_not_dropped; full suite
1496/0; FROZEN_HASH re-sealed.

Closes #1709
@gHashTag
gHashTag enabled auto-merge August 5, 2026 14:56
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-05 14:56:35 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 0
PRs with All Checks Green 50
READY 0
FAILING 0
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=373978ca4db8 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 4bbbf91 into master Aug 5, 2026
18 checks passed
gHashTag added a commit that referenced this pull request Aug 5, 2026
docs(now): restore NOW.md coordination log truncated by #1710's script bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: function with tuple return type (-> (T,U)) is silently dropped

1 participant