Repository navigation
fix(parser): tuple return types no longer silently drop the function - #1710
Merged
Merged
Conversation
The return-type parser handled Ident/[...]/void/*T but not '(' (tuple). On
'-> (u32, u32)' it desynced and the whole function vanished from the AST,
breaking every backend. Add a LParen branch that captures (T, U, ...).
Function with tuple return now survives with correct signature.
Part 1 of tuple support (#1702); body-lowering + let (a,b) destructuring are
follow-ups. Regression test test_tuple_return_type_not_dropped; full suite
1496/0; FROZEN_HASH re-sealed.
Closes #1709
gHashTag
enabled auto-merge
August 5, 2026 14:56
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 5, 2026
gHashTag
added a commit
that referenced
this pull request
Aug 5, 2026
docs(now): restore NOW.md coordination log truncated by #1710's script bug
This was referenced Aug 5, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return-type parser had no
(branch →-> (u32,u32)desynced and the whole function vanished from the AST (1 FnDecl vs 2), breaking all backends. Adds aLParenbranch capturing(T, U, …); the function now survives with the correct signature.Verified: regression test
test_tuple_return_type_not_dropped, full suite 1496/0, non-tuple specs unaffected, FROZEN_HASH re-sealed. Part 1 of tuple support (#1702) — body-lowering +let (a,b)destructuring are clearly-scoped follow-ups.Closes #1709